Re: [PHP-DEV] Rename Fiber::this() to Fiber::getCurrent()

2021-06-15 Thread Joe Watkins
This doesn't look like the sort of detail we need to vote on. It would be nice if this were made in time for the migration guide and other doc to be prepared for 8.1. Let's move forward, please ... Cheers Joe On Tue, 15 Jun 2021 at 21:54, Larry Garfield wrote: > On Tue, Jun 15, 2021, at 2:01

Re: [PHP-DEV] Rename Fiber::this() to Fiber::getCurrent()

2021-06-15 Thread Larry Garfield
On Tue, Jun 15, 2021, at 2:01 PM, Aaron Piotrowski wrote: > Hi all, > > During the Fiber RFC vote, several people noted that they objected to > the name Fiber::this() for the method returning the currently executing > Fiber object. > > I'd like to propose renaming this method to Fiber::getCurre

[PHP-DEV] Rename Fiber::this() to Fiber::getCurrent()

2021-06-15 Thread Aaron Piotrowski
Hi all, During the Fiber RFC vote, several people noted that they objected to the name Fiber::this() for the method returning the currently executing Fiber object. I'd like to propose renaming this method to Fiber::getCurrent(). A simple PR for the rename: https://github.com/php/php-src/pull/71