Re: [PHP-DEV] Removing support for the disable_classes INI setting

2023-08-15 Thread Peter Kokot
On Mon, 14 Aug 2023 at 16:18, G. P. B. wrote: > Hello internals, > > While working on some DNF type bugs, I discovered some major issues around > the disable_classes INI setting implementation. Such as: > > - A double-free of the type of a typed property > - A use after free (which segfaults) whe

Re: [PHP-DEV] Removing support for the disable_classes INI setting

2023-08-14 Thread G. P. B.
On Mon, 14 Aug 2023 at 20:03, Larry Garfield wrote: > However, I think it should not get an exception for code-freeze. At best, > I could see a deprecation warning on it in 8.3 and remove in 8.4/9, but I > defer to the RMs on that front. > In its current state, this INI setting does nothing oth

Re: [PHP-DEV] Removing support for the disable_classes INI setting

2023-08-14 Thread Juliette Reinders Folmer
On 14-8-2023 16:17, G. P. B. wrote: Hello internals, While working on some DNF type bugs, I discovered some major issues around the disable_classes INI setting implementation. Such as: - A double-free of the type of a typed property - A use after free (which segfaults) when trying to access a p

Re: [PHP-DEV] Removing support for the disable_classes INI setting

2023-08-14 Thread Larry Garfield
On Mon, Aug 14, 2023, at 2:17 PM, G. P. B. wrote: > Hello internals, > > While working on some DNF type bugs, I discovered some major issues around > the disable_classes INI setting implementation. Such as: > > - A double-free of the type of a typed property > - A use after free (which segfaults) w

[PHP-DEV] Removing support for the disable_classes INI setting

2023-08-14 Thread G. P. B.
Hello internals, While working on some DNF type bugs, I discovered some major issues around the disable_classes INI setting implementation. Such as: - A double-free of the type of a typed property - A use after free (which segfaults) when trying to access a property defined on a disabled class th