Re: [PHP-DEV] Re: re-proposal of pecl/phar for inclusion in core

2008-01-28 Thread David Coallier
On Jan 28, 2008 2:09 PM, Steph Fox <[EMAIL PROTECTED]> wrote: > > phar's zip support. The tests simply need to be modified to create the > > zips using pecl/phar and copy the filename to one phar doesn't already > > know about, and the failures will go away. > > I thought you wanted 'pure' zips fo

Re: [PHP-DEV] Re: re-proposal of pecl/phar for inclusion in core

2008-01-28 Thread Steph Fox
phar's zip support. The tests simply need to be modified to create the zips using pecl/phar and copy the filename to one phar doesn't already know about, and the failures will go away. I thought you wanted 'pure' zips for the tests - that told me! So how do I create a zip with ext/phar then, o

Re: [PHP-DEV] Re: re-proposal of pecl/phar for inclusion in core

2008-01-28 Thread Gregory Beaver
Marcus Boerger wrote: > Hello Steph, > > so you mean we do not have to confuse our uses by solution 2a becasue we > only have the minimum subset of zip in phar that ohar actually needs? > > Although phar can be used to create and read any zip archive, it will automatically add the file ".ph

Re: [PHP-DEV] Re: re-proposal of pecl/phar for inclusion in core

2008-01-28 Thread Steph Fox
Hi Marcus, so you mean we do not have to confuse our uses by solution 2a becasue we only have the minimum subset of zip in phar that ohar actually needs? Yep. But Greg can explain better. - Steph -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.

Re: [PHP-DEV] Re: re-proposal of pecl/phar for inclusion in core

2008-01-28 Thread Marcus Boerger
Hello Steph, so you mean we do not have to confuse our uses by solution 2a becasue we only have the minimum subset of zip in phar that ohar actually needs? marcus Monday, January 28, 2008, 7:01:42 PM, you wrote: > Hi Marcus, >> 1. include phar in core >> 2.a. add ext/zip compatible funct

Re: [PHP-DEV] Re: re-proposal of pecl/phar for inclusion in core

2008-01-28 Thread Steph Fox
Hi Marcus, 1. include phar in core 2.a. add ext/zip compatible functions and replace ext/zip 2.b. change ext/zip to use zip lib of pahr and add stream support 3. drop ability to disable spl I have no preference between 2a or 2b. Though technically I guess that 2a is probably much faster to

[PHP-DEV] Re: re-proposal of pecl/phar for inclusion in core

2008-01-28 Thread Marcus Boerger
Hello Gregory, My point of view is this action list: 1. include phar in core 2.a. add ext/zip compatible functions and replace ext/zip 2.b. change ext/zip to use zip lib of pahr and add stream support 3. drop ability to disable spl I have no preference between 2a or 2b. Though technically