Re: [PHP-DEV] Re: mysqli tests breaking

2011-09-05 Thread Ulf Wendel
Am 05.09.2011 12:00, schrieb Stas Malyshev: Hi! On 9/5/11 2:49 AM, Ulf Wendel wrote: Returning a relevant value for stmt_num_rows() seems a valid feature request that makes perfectly sense to me and is somewhat in line with the vague non-PS documentation of the case. It's not a good situation

Re: [PHP-DEV] Re: mysqli tests breaking

2011-09-05 Thread Stas Malyshev
Hi! On 9/5/11 2:49 AM, Ulf Wendel wrote: Returning a relevant value for stmt_num_rows() seems a valid feature request that makes perfectly sense to me and is somewhat in line with the vague non-PS documentation of the case. It's not a good situation where mysqlnd and libmysql have different s

Re: [PHP-DEV] Re: mysqli tests breaking

2011-09-05 Thread Ulf Wendel
Am 05.09.2011 11:37, schrieb Stas Malyshev: Hi! On 9/5/11 2:29 AM, Ulf Wendel wrote: - BC breakage is impossible because behavior is undefined - update test, issue gone OK, since you say it's not the intended behavior to be relied upon, I'll remove this check from the test (if nobody beats me

Re: [PHP-DEV] Re: mysqli tests breaking

2011-09-05 Thread Pierre Joye
On Mon, Sep 5, 2011 at 11:37 AM, Stas Malyshev wrote: > Hi! > > On 9/5/11 2:29 AM, Ulf Wendel wrote: >> >>   - BC breakage is impossible because behavior is undefined >>   - update test, issue gone > > OK, since you say it's not the intended behavior to be relied upon, I'll > remove this check fro

Re: [PHP-DEV] Re: mysqli tests breaking

2011-09-05 Thread Stas Malyshev
Hi! On 9/5/11 2:29 AM, Ulf Wendel wrote: - BC breakage is impossible because behavior is undefined - update test, issue gone OK, since you say it's not the intended behavior to be relied upon, I'll remove this check from the test (if nobody beats me to it). -- Stanislav Malyshev, Softw

Re: [PHP-DEV] Re: mysqli tests breaking

2011-09-05 Thread Ulf Wendel
Am 04.09.2011 06:35, schrieb Stas Malyshev: The ones I'm most worried about are: 1. mysqli_stmt_num_rows() is expected to return number of rows after all rows were fetched while returning 0 before that. libmysql definitely Yes, here the test assumes a marginally different behavior. The test n

[PHP-DEV] Re: mysqli tests breaking

2011-09-03 Thread Stas Malyshev
Hi! I've tried with latest mysql library and as I suspected, most of the issues still stay. The ones I'm most worried about are: 1. mysqli_stmt_num_rows() is expected to return number of rows after all rows were fetched while returning 0 before that. libmysql definitely doesn't do that, in f