Re: [PHP-DEV] Re: hash BLAKE3

2020-10-31 Thread Hans Henrik Bergan
@Levi > However, I still see CPU related code in get_cpu_features. Are you > sure you pushed the right thing? I think it's correct, yes, the problem is ext/hash/blake3/blake3_dispatch.c, which is just a copypaste of the upstream https://github.com/BLAKE3-team/BLAKE3/blob/master/c/blake3_dispatch.

Re: [PHP-DEV] Re: hash BLAKE3

2020-10-30 Thread Levi Morrison via internals
On Fri, Oct 30, 2020 at 6:08 PM Hans Henrik Bergan wrote: > > hmm i'll try again, > made another PR: https://github.com/php/php-src/pull/6393 > > this PR is an alternative to https://github.com/php/php-src/pull/6358 > with some notable differences, > > - this PR is roughly 1700 SLOC, compared to #

[PHP-DEV] Re: hash BLAKE3

2020-10-30 Thread Hans Henrik Bergan
hmm i'll try again, made another PR: https://github.com/php/php-src/pull/6393 this PR is an alternative to https://github.com/php/php-src/pull/6358 with some notable differences, - this PR is roughly 1700 SLOC, compared to #6358 at roughly 31,000 SLOC - this PR only bundles the "portable C" vers