Hello Nuno,
most of .re2c output can be overwritten anyway through commandline.
For the others we probably need a sed call after generation.
marcus
Monday, October 24, 2005, 9:23:01 PM, you wrote:
> Paths can be made relative (at least re2c parsers, I don't know about
> flex/bison).
> This w
Paths can be made relative (at least re2c parsers, I don't know about
flex/bison).
This would just need a tweak in the makefile, to cd to the folder where the
'file.re' is, instead of calling re2c with an absolute path. I'm sure Jani
can do this easily.
Without this, lcov stops in the first pars
Hello Nuno,
Saturday, October 22, 2005, 2:01:31 PM, you wrote:
> Hi Marcus.
> Thanks for reviewing the patch!
> I agree with you that using environment vars is excessive in this script.
> The only reason I've used it is to allow the user to pass arguments to
> valgrind (like the suppresions fi
Hi Marcus.
Thanks for reviewing the patch!
I agree with you that using environment vars is excessive in this script.
The only reason I've used it is to allow the user to pass arguments to
valgrind (like the suppresions file). After reading the valgrind manual,
I've discovered that it is also p
Hello Nuno,
the use of environment is inacceptable here. Just invent some new switch.
Probably "run.tests.php -m" as in memleaks? Also defining VALGRIND and then
doing 'system_with_timeout(VALGRIND.$cmd);' is ugly style and there is no
need to have that define anyway. You could easily just chang
Hi Marcus,
And what about generate the files with *relative* paths. The #line
directives are very usefull for debuging, so I think they should continue
there, but with relative paths, not to the path where Ilia or Jani have
their php sources.
I've updated my patch (to latest HEAD) to 'run-te
Hello Nuno,
we might want to increase re2c version requirement and have re2c omit
those lines for gcov builds (re2c -i).
marcus
Thursday, October 20, 2005, 9:29:24 PM, you wrote:
>> You can get rid of the "bogus" #line lines with using
>> the genfiles script. Don't even dream about ge
You can get rid of the "bogus" #line lines with using
the genfiles script. Don't even dream about getting rid
of them in the files by using the -L or -l options for flex/bison!!
--Jani
No, of corse not :) I've used that just for testing.
I was mainly refering to the re2c files,
