Re: [PHP-DEV] Re: curl_multi_info_read patch review

2006-05-02 Thread Ilia Alshanetsky
Apply this to HEAD for now, and once I'll review I'll give a you a go ahead for PHP_5_2 branch that will be created. For now we'll just add it to our 5.2 wiki TODO list. On 2-May-06, at 5:29 PM, Brian J. France wrote: PHP_5_1 and head or just head? It could be considered bug fix since cur

Re: [PHP-DEV] Re: curl_multi_info_read patch review

2006-05-02 Thread Sterling Hughes
not having tested it, i don't know. this is certainly a RM question, but if it doesn't break the compile, it does not look like it has the potential to damage previously existing infrastructure. -sterling On 5/2/06, Brian J. France <[EMAIL PROTECTED]> wrote: PHP_5_1 and head or just head? It

Re: [PHP-DEV] Re: curl_multi_info_read patch review

2006-05-02 Thread Brian J. France
PHP_5_1 and head or just head? It could be considered bug fix since curl_multi_info_read was there, but not implemented. Brian On May 2, 2006, at 4:56 PM, Sterling Hughes wrote: please commit it, looks good. thanks, sterling On 5/2/06, Brian J. France <[EMAIL PROTECTED]> wrote: Some guy

[PHP-DEV] Re: curl_multi_info_read patch review

2006-05-02 Thread Sterling Hughes
please commit it, looks good. thanks, sterling On 5/2/06, Brian J. France <[EMAIL PROTECTED]> wrote: Some guys at work created this patch and have been running with it for a while now. Could I get a few more eyeballs on this? http://www.brianfrance.com/software/php/curl_multi_read.patch Quot