Re: [PHP-DEV] Re: Zend signed multiply for ARM

2013-01-17 Thread Ard Biesheuvel
On 17 January 2013 16:22, Rasmus Lerdorf wrote: > Welcome back Ard. Looks good to me, but I don't have an ARM box to test Thanks! I have done some manual testing on the corner cases, both on the 64-bit ARMv8 emulator and a 32-bit TI Beaglebone, and have also run the test cases in the Zend/ folde

Re: [PHP-DEV] Re: Zend signed multiply for ARM

2013-01-17 Thread Rasmus Lerdorf
Welcome back Ard. Looks good to me, but I don't have an ARM box to test on. Go to http://php.net/git-php.php and fill in the form at the bottom there and we will get you set up with a git account unless you already have one. I did a quick search and couldn't find it. -Rasmus -- PHP Internals - P

[PHP-DEV] Re: Zend signed multiply for ARM

2013-01-17 Thread Ard Biesheuvel
Gmail ate my attachment the 1st time, trying Thunderbird instead ... diff --git a/Zend/zend_multiply.h b/Zend/zend_multiply.h index c3c9657..3053f8b 100644 --- a/Zend/zend_multiply.h +++ b/Zend/zend_multiply.h @@ -13,7 +13,7 @@ | lice...@zend.com so we can mail you a copy immediately.