[PHP-DEV] Re: Safe Temporary Cleanup on Exception (Variable Liveness)

2015-11-11 Thread Dmitry Stogov
It looks like the last version of the patch https://github.com/php/php-src/pull/1634 solves all the problems (except for reported by Nikita "unknown liveness in finally" - Zend/tests/temporary_cleaning_010.phpt). Please, analyse the patch and

[PHP-DEV] Re: Safe Temporary Cleanup on Exception (Variable Liveness)

2015-11-10 Thread Xinchen Hui
On Wed, Nov 11, 2015 at 11:10 AM, Xinchen Hui wrote: > Hey: > > On Tue, Nov 10, 2015 at 7:29 PM, Dmitry Stogov wrote: > >> >> >> On Tue, Nov 10, 2015 at 1:42 PM, Nikita Popov >> wrote: >> >>> On Tue, Nov 10, 2015 at 10:53 AM, Dmitry Stogov wrote: >>> Hi, Please take a look into

[PHP-DEV] Re: Safe Temporary Cleanup on Exception (Variable Liveness)

2015-11-10 Thread Xinchen Hui
Hey: On Tue, Nov 10, 2015 at 7:29 PM, Dmitry Stogov wrote: > > > On Tue, Nov 10, 2015 at 1:42 PM, Nikita Popov > wrote: > >> On Tue, Nov 10, 2015 at 10:53 AM, Dmitry Stogov wrote: >> >>> Hi, >>> >>> Please take a look into >>> https://gist.github.com/dstogov/43eaa3f3b68583877322 >>> >>> This i

[PHP-DEV] Re: Safe Temporary Cleanup on Exception (Variable Liveness)

2015-11-10 Thread Dmitry Stogov
I've committed unrelated and obvious parts (without semantic changes). The updated and extended patch now is much more clean https://gist.github.com/dstogov/43eaa3f3b68583877322 Anyway, it's still incomplete. Thanks. Dmitry. On Tue, Nov 10, 2015 at 2:29 PM, Dmitry Stogov wrote: > > > On Tue, No

[PHP-DEV] Re: Safe Temporary Cleanup on Exception (Variable Liveness)

2015-11-10 Thread Dmitry Stogov
On Tue, Nov 10, 2015 at 1:42 PM, Nikita Popov wrote: > On Tue, Nov 10, 2015 at 10:53 AM, Dmitry Stogov wrote: > >> Hi, >> >> Please take a look into >> https://gist.github.com/dstogov/43eaa3f3b68583877322 >> >> This is variation on Bob's idea about variable liveness. >> The patch is incomplete.

[PHP-DEV] Re: Safe Temporary Cleanup on Exception (Variable Liveness)

2015-11-10 Thread Nikita Popov
On Tue, Nov 10, 2015 at 10:53 AM, Dmitry Stogov wrote: > Hi, > > Please take a look into > https://gist.github.com/dstogov/43eaa3f3b68583877322 > > This is variation on Bob's idea about variable liveness. > The patch is incomplete. Liveness construction is still naive. However, > all tests are pa

[PHP-DEV] Re: Safe Temporary Cleanup on Exception (Variable Liveness)

2015-11-10 Thread Dmitry Stogov
BTW: I think, part of this patch (without zend_check_live_ranges) may be good enough, as a first step. It should keep the current PHP-5/7.0 behavior with new data structures. Thanks. Dmitry. On Tue, Nov 10, 2015 at 12:53 PM, Dmitry Stogov wrote: > Hi, > > Please take a look into > https://gist.