[PHP-DEV] Re: Reverting ext/mbstring patch

2011-03-03 Thread Moriyoshi Koizumi
Hi, The obvious problem looked like handling of internal encoding. When the script is written in an encoding that is incompatible with the lexer, the script is converted into internal encoding (input_filter) for parsing, and then gets every string literal converted back to the original encoding (

[PHP-DEV] Re: Reverting ext/mbstring patch

2011-03-02 Thread Dmitry Stogov
Hi Moriyoshi, OK, I thought the email was lost, so ignore the email I just resent. In general I like your patch and I would glad to see it fixed. I already tried to make some fixes. See the attached patch. Thanks. Dmitry. On 03/02/2011 11:51 PM, Moriyoshi Koizumi wrote: Hey, I think I can f

[PHP-DEV] Re: Reverting ext/mbstring patch

2011-03-02 Thread Moriyoshi Koizumi
Hey, I think I can fix it somehow. Please don't be haste with it. I am going to look into it. Moriyoshi On Tue, Mar 1, 2011 at 11:35 PM, Dmitry Stogov wrote: > Hi, > > I'm going to revert Moriyoshi patch from December and some following fixes. > > I like the idea of the patch, but it just doe