[PHP-DEV] Re: RFC [Discussion]: Randomizer Additions

2022-11-07 Thread Joshua Rüsweg via internals
Hi You can find the RFC at: https://wiki.php.net/rfc/randomizer_additions Proof of concept implementation is in: * https://github.com/php/php-src/pull/9664 * https://github.com/php/php-src/pull/9679 we believe we resolved all open questions with the RFC and there was no recent feedback wit

Re: [PHP-DEV] Re: RFC [Discussion]: Randomizer Additions

2022-10-31 Thread Tim Düsterhus
Hi On 10/29/22 00:44, Jordan LeDoux wrote: I had a discussion with Tim about this naming topic as well, and want to convey my suggestion along with the reasoning. I think the enum should be `Random\IntervalBoundary` with the enum cases: Yes, I agree this is a much better name for the enum its

Re: [PHP-DEV] Re: RFC [Discussion]: Randomizer Additions

2022-10-28 Thread Jordan LeDoux
On Fri, Oct 28, 2022 at 12:23 PM Joshua Rüsweg via internals < internals@lists.php.net> wrote: > Hi > > > You can find the RFC at: > > > > https://wiki.php.net/rfc/randomizer_additions > > Tim Düsterhus and I have updated the RFC and have broadly adopted the > proposals. > > Firstly we have rename

[PHP-DEV] Re: RFC [Discussion]: Randomizer Additions

2022-10-28 Thread Joshua Rüsweg via internals
Hi You can find the RFC at: https://wiki.php.net/rfc/randomizer_additions Tim Düsterhus and I have updated the RFC and have broadly adopted the proposals. Firstly we have renamed the `getBytesFromAlphabet` to `getBytesFromString` as Larry Garfield suggested. Secondly, we have extended t