Re: [PHP-DEV] Re: Patch: Reflection Exception Messages

2010-04-09 Thread David Soria Parra
> >> @@ -3602,7 +3602,7 @@ > >>} > >>} > >>zend_throw_exception_ex(reflection_exception_ptr, 0 TSRMLS_CC, > >> - "Property %s does not exist", name); > >> + "Property %s::%s does not exist", ce->name, name); > >> } > >> /* }}}

Re: [PHP-DEV] Re: Patch: Reflection Exception Messages

2010-04-09 Thread Pierre Joye
On Fri, Apr 9, 2010 at 9:26 AM, Lukas Kahwe Smith wrote: >> looks good for me. if there are no objections from someone else I'll >> commit it tomorrow. > > > @David: seems like you forgot to commit this? David will be back in 10 days. Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net |

Re: [PHP-DEV] Re: Patch: Reflection Exception Messages

2010-04-09 Thread Lukas Kahwe Smith
On 28.03.2010, at 17:59, David Soria Parra wrote: > On 2010-03-28, Benjamin Eberlei wrote: >> Index: ext/reflection/php_reflection.c >> === >> --- ext/reflection/php_reflection.c (revision 296963) >> +++ ext/reflection/php_reflecti

[PHP-DEV] Re: Patch: Reflection Exception Messages

2010-03-28 Thread David Soria Parra
On 2010-03-28, Benjamin Eberlei wrote: > Index: ext/reflection/php_reflection.c >=== > --- ext/reflection/php_reflection.c (revision 296963) > +++ ext/reflection/php_reflection.c (working copy) > @@ -3425,7 +3425,7 @@ > } el