Re: [PHP-DEV] Re: PHP 7.3 zif_handler changes

2018-07-23 Thread Derick Rethans
On Tue, 10 Jul 2018, Christoph M. Becker wrote: > On 09.07.2018 at 11:41, Derick Rethans wrote: > > > On Wed, 4 Jul 2018, Christoph M. Becker wrote: > > > >> On 04.07.2018 at 12:24, Nikita Popov wrote: > >> > >>> On Wed, Jul 4, 2018 at 11:32 AM, Christoph M. Becker > >>> wrote: > >>> > On

Re: [PHP-DEV] Re: PHP 7.3 zif_handler changes

2018-07-10 Thread Christoph M. Becker
On 09.07.2018 at 11:41, Derick Rethans wrote: > On Wed, 4 Jul 2018, Christoph M. Becker wrote: > >> On 04.07.2018 at 12:24, Nikita Popov wrote: >> >>> On Wed, Jul 4, 2018 at 11:32 AM, Christoph M. Becker >>> wrote: >>> On 04.07.2018 at 01:16, Jan Ehrhardt wrote: > Another one: some

Re: [PHP-DEV] Re: PHP 7.3 zif_handler changes

2018-07-09 Thread Derick Rethans
On Wed, 4 Jul 2018, Christoph M. Becker wrote: > On 04.07.2018 at 12:24, Nikita Popov wrote: > > > On Wed, Jul 4, 2018 at 11:32 AM, Christoph M. Becker > > wrote: > > > >> On 04.07.2018 at 01:16, Jan Ehrhardt wrote: > >> > >>> Another one: some extensioms suffer from the fact that the macro GC_

Re: [PHP-DEV] Re: PHP 7.3 zif_handler changes

2018-07-04 Thread Jan Ehrhardt
Nikita Popov in php.internals (Wed, 4 Jul 2018 12:24:10 +0200): >On Wed, Jul 4, 2018 at 11:32 AM, Christoph M. Becker >wrote: > >> zend_gc_status status; >> zend_gc_get_status(&status); >> if (status.runs) { >> > >The correct way to handle this is to implement a proper get_gc() handler, >whi

Re: [PHP-DEV] Re: PHP 7.3 zif_handler changes

2018-07-04 Thread Christoph M. Becker
On 04.07.2018 at 12:24, Nikita Popov wrote: > On Wed, Jul 4, 2018 at 11:32 AM, Christoph M. Becker > wrote: > >> On 04.07.2018 at 01:16, Jan Ehrhardt wrote: >> >>> Another one: some extensioms suffer from the fact that the macro GC_G >>> was removed from >>> https://github.com/php/php-src/blob/m

Re: [PHP-DEV] Re: PHP 7.3 zif_handler changes

2018-07-04 Thread Nikita Popov
On Wed, Jul 4, 2018 at 11:32 AM, Christoph M. Becker wrote: > On 04.07.2018 at 01:16, Jan Ehrhardt wrote: > > > Another one: some extensioms suffer from the fact that the macro GC_G > > was removed from > > https://github.com/php/php-src/blob/master/Zend/zend_gc.h > > Some of the removed function

Re: [PHP-DEV] Re: PHP 7.3 zif_handler changes

2018-07-04 Thread Christoph M. Becker
On 04.07.2018 at 11:32, Christoph M. Becker wrote: >> Are the changes to zend_gc.h documneted? > > Apparently not. […] Fixed with . -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing

Re: [PHP-DEV] Re: PHP 7.3 zif_handler changes

2018-07-04 Thread Christoph M. Becker
On 04.07.2018 at 01:16, Jan Ehrhardt wrote: > Another one: some extensioms suffer from the fact that the macro GC_G > was removed from > https://github.com/php/php-src/blob/master/Zend/zend_gc.h > Some of the removed functionality has been reintroduced in gc_status > https://github.com/php/php-src

Re: [PHP-DEV] Re: PHP 7.3 zif_handler changes

2018-07-03 Thread Jan Ehrhardt
"Christoph M. Becker" in php.internals (Thu, 28 Jun 2018 12:56:43 +0200): >Apparently, zval_ptr_dtor() had to be replaced with >zval_internal_dtor() to avoid a segfault with PHP 7.3. Is this caused >by a change in the engine? If so, is this change documented? Another one: some extensioms suffer

Re: [PHP-DEV] Re: PHP 7.3 zif_handler changes

2018-06-28 Thread Christoph M. Becker
On 28.06.2018 at 06:22, Xinchen Hui wrote: > FAST_CALL should only affects win32. and it can bring some improvement in > win32.. > > People should use zif_handler instead of define there own from now on, I > think documented it in UPGRADING is enough Thanks! I've pushed

Re: [PHP-DEV] Re: PHP 7.3 zif_handler changes

2018-06-27 Thread Xinchen Hui
Hey: On Wed, Jun 27, 2018 at 9:44 PM Christoph M. Becker wrote: > On 27.06.2018 at 08:47, Jan Ehrhardt wrote: > > > "Christoph M. Becker" in php.internals (Tue, 26 Jun 2018 13:15:32 > > +0200): > > > >> On 26.06.2018 at 08:42, Jan Ehrhardt wrote: > >> > >>> > https://github.com/php/php-src/blob/p

[PHP-DEV] Re: PHP 7.3 zif_handler changes

2018-06-27 Thread Christoph M. Becker
On 27.06.2018 at 08:47, Jan Ehrhardt wrote: > "Christoph M. Becker" in php.internals (Tue, 26 Jun 2018 13:15:32 > +0200): > >> On 26.06.2018 at 08:42, Jan Ehrhardt wrote: >> >>> https://github.com/php/php-src/blob/php-7.3.0alpha2/UPGRADING.INTERNALS >>> >>> pecl_http: >>> |php_http_client_curl_use

[PHP-DEV] Re: PHP 7.3 zif_handler changes

2018-06-26 Thread Jan Ehrhardt
"Christoph M. Becker" in php.internals (Tue, 26 Jun 2018 13:15:32 +0200): >On 26.06.2018 at 08:42, Jan Ehrhardt wrote: > >> https://github.com/php/php-src/blob/php-7.3.0alpha2/UPGRADING.INTERNALS >> >> pecl_http: >> |php_http_client_curl_user.c(190): error C2440: '=': cannot convert from >> 'void

[PHP-DEV] Re: PHP 7.3 zif_handler changes

2018-06-26 Thread Christoph M. Becker
On 26.06.2018 at 08:42, Jan Ehrhardt wrote: > Apparently, there were changes in the zend internal functions handler > (aka zif_handler), but I cannot find any info on it. Neither in the > linked documents, nor in > https://github.com/php/php-src/blob/php-7.3.0alpha2/UPGRADING.INTERNALS > > I ran