Re: [PHP-DEV] Re: One more critical problem in 5.4

2012-02-01 Thread Michael Wallner
On Wed, 01 Feb 2012 11:57:08 +0200, Lior Kaplan wrote: > On Tue, 2012-01-31 at 03:58 -0500, Michael Wallner wrote: >> On Tue, 31 Jan 2012 10:04:34 +0200, yoram bar haim wrote: >> >> > Sorry, problem is not solved yet. >> >> I committed a possible fix to trunk. It's pretty much along the patch >

Re: [PHP-DEV] Re: One more critical problem in 5.4

2012-02-01 Thread jpauli
On Wed, Feb 1, 2012 at 10:57 AM, Lior Kaplan wrote: > On Tue, 2012-01-31 at 03:58 -0500, Michael Wallner wrote: > > On Tue, 31 Jan 2012 10:04:34 +0200, yoram bar haim wrote: > > > > > Sorry, problem is not solved yet. > > > > I committed a possible fix to trunk. It's pretty much along > > the pa

Re: [PHP-DEV] Re: One more critical problem in 5.4

2012-02-01 Thread Lior Kaplan
On Tue, 2012-01-31 at 03:58 -0500, Michael Wallner wrote: > On Tue, 31 Jan 2012 10:04:34 +0200, yoram bar haim wrote: > > > Sorry, problem is not solved yet. > > I committed a possible fix to trunk. It's pretty much along > the patch from you, I just hat to fix crashes in the cli server > and ne

[PHP-DEV] Re: One more critical problem in 5.4

2012-02-01 Thread yoram bar haim
Just to make everything clear, I'm not sure if it was my mistake change 5_4 branch, but currently 5_4 branch (after 322964 commit) solves the header problem. Thanks for the work. > On Tue, 31 Jan 2012 10:04:34 +0200, yoram bar haim wrote: > >> Sorry, problem is not solved yet. > > I committed a

[PHP-DEV] Re: One more critical problem in 5.4

2012-01-31 Thread Michael Wallner
Thank you. Now I just need to figure why the cli servers styles are printed to stdio... On Tue, 31 Jan 2012 11:16:40 +0200, yoram bar haim wrote: > The patch to trunk does solve the FastCGI headers problem. tested with > PHP fastcgi on top of lighttpd. -- PHP Internals - PHP Runtime Develop

[PHP-DEV] Re: One more critical problem in 5.4

2012-01-31 Thread yoram bar haim
The patch to trunk does solve the FastCGI headers problem. tested with PHP fastcgi on top of lighttpd. > On Tue, 31 Jan 2012 10:04:34 +0200, yoram bar haim wrote: > >> Sorry, problem is not solved yet. > > I committed a possible fix to trunk. It's pretty much along > the patch from you, I just h

[PHP-DEV] Re: One more critical problem in 5.4

2012-01-31 Thread Michael Wallner
On Tue, 31 Jan 2012 10:04:34 +0200, yoram bar haim wrote: > Sorry, problem is not solved yet. I committed a possible fix to trunk. It's pretty much along the patch from you, I just hat to fix crashes in the cli server and need to do some more testing before merging into PHP_5_4. Thank you for y

Re: [PHP-DEV] Re: One more critical problem in 5.4

2012-01-30 Thread Stas Malyshev
Hi! should be reproducible with this simple script: http://www.google.com";); Could you check with a recent checkout? Looks like the last patch from Michael fixed that (at least it works for me). -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext

Re: [PHP-DEV] Re: One more critical problem in 5.4

2012-01-30 Thread yoram bar haim
As I sayed, my patch was not suggusted as fix, Dmitry is write about possible side effetcs, it was added only to prove that the problem is what we think it is. On Monday, January 30, 2012 05:42:11 PM Dmitry Stogov wrote: > Hi Mike, > > I confirm the bug. In case of empty output HTTP headers are

Re: [PHP-DEV] Re: One more critical problem in 5.4

2012-01-30 Thread Dmitry Stogov
Hi Mike, I confirm the bug. In case of empty output HTTP headers are sent to stdout or stderr instead of FastCGI stream. To reproduce I configured nginx to use PHP FastCGI server on UNIX socket, then launched (sapi/cgi/php-cgi -b /tmp/fcgi-php5) and performed several request to empty PHP fil

[PHP-DEV] Re: One more critical problem in 5.4

2012-01-30 Thread yoram bar haim
I Debugged the issue described here by lior. the problem is : in php_request_shutdown() we call sapi_send_headers() after php_output_deactivate(). at this point, in main/output.c, OG(flags) & PHP_OUTPUT_ACTIVATED is false so php_output_write_unbuffered() calls ph

[PHP-DEV] Re: One more critical problem in 5.4

2012-01-30 Thread Lior Kaplan
> On Wed, 25 Jan 2012 09:13:43 -0800, Stas Malyshev wrote: > > > Hi! > > > >> We've just found one more critical problem in 5.4. > >> > >> Apache/PHP crashes in case of error on startup, when > >> display_startup_errors=1. It's probably related to new output API. > >> > >> I afraid it may affect

[PHP-DEV] Re: One more critical problem in 5.4

2012-01-25 Thread Michael Wallner
On Wed, 25 Jan 2012 19:07:15 +0400, Dmitry Stogov wrote: > Hi Stas, > > We've just found one more critical problem in 5.4. > > Apache/PHP crashes in case of error on startup, when > display_startup_errors=1. It's probably related to new output API. > > I afraid it may affect many php users. ...

[PHP-DEV] Re: One more critical problem in 5.4

2012-01-25 Thread yoram bar haim
the main difference is php_sprintf in 5.3 it calls OG(php_body_write) which points to php_default_output_func at tha point. in 5.4 it calls php_output_write, which writes output via SAPI. On Wednesday, January 25, 2012 05:07:15 PM Dmitry Stogov wrote: > Hi Stas, > > We've just found one more cr