Re: [PHP-DEV] Re: More valuable error message handling

2006-07-18 Thread Ilia Alshanetsky
Just because we have objects it does not mean we need to use them all the time. In this instance IMO it makes absolutely no sense to use an object, it only creates extra overhead. If you want the patch to be included in 5.2, please change the function to return an associated array. On 18

Re: [PHP-DEV] Re: More valuable error message handling

2006-07-18 Thread Antony Dovgal
On 18.07.2006 13:38, Michael Wallner wrote: Ilia Alshanetsky wrote: Looks good to me, although I'd prefer you returned an associated array rather then an object. What for do we have object dereferencing then? As gimmick or buzzword? Definitely not for returning errors. Array perfectly fits h

Re: [PHP-DEV] Re: More valuable error message handling

2006-07-18 Thread Michael Wallner
Ilia Alshanetsky wrote: Looks good to me, although I'd prefer you returned an associated array rather then an object. What for do we have object dereferencing then? As gimmick or buzzword? $err = error_get_last(); echo $err["message"]; vs. echo error_get_last()->message; One can still cas

Re: [PHP-DEV] Re: More valuable error message handling

2006-07-17 Thread Ilia Alshanetsky
Looks good to me, although I'd prefer you returned an associated array rather then an object. On 17-Jul-06, at 6:03 AM, Michael Wallner wrote: Lukas Smith wrote: thats why i said that i would like to atleast be able to get the last error without having to mess/check track_errors ini settin

Re: [PHP-DEV] Re: More valuable error message handling

2006-07-17 Thread Zeev Suraski
Agreed - it looks good, but should return an array instead of an object. Zeev At 00:33 18/07/2006, Ilia Alshanetsky wrote: Looks good to me, although I'd prefer you returned an associated array rather then an object. On 17-Jul-06, at 6:03 AM, Michael Wallner wrote: Lukas Smith wrote: tha

Re: [PHP-DEV] Re: More valuable error message handling

2006-07-17 Thread Marcus Boerger
Hello Michael, looks quite good now :-) If it were up to me i'd say commit. best regards marcus Monday, July 17, 2006, 12:03:43 PM, you wrote: > Lukas Smith wrote: >> thats why i said that i would like to atleast be able to get the last >> error without having to mess/check track_errors ini

Re: [PHP-DEV] Re: More valuable error message handling

2006-07-17 Thread Michael Wallner
Lukas Smith wrote: thats why i said that i would like to atleast be able to get the last error without having to mess/check track_errors ini setting. i think this is an acceptable compromise to always store the last error, no? this covers 100% of all use cases i ever had where i would mess with

Re: [PHP-DEV] Re: More valuable error message handling

2006-07-11 Thread Lukas Smith
Marcus Boerger wrote: Hello Michael, yep, here too. track_errors is an optimizations when you don't want to debug but simply use your app. thats why i said that i would like to atleast be able to get the last error without having to mess/check track_errors ini setting. i think this is an a

Re: [PHP-DEV] Re: More valuable error message handling

2006-07-11 Thread Marcus Boerger
Hello Michael, yep, here too. track_errors is an optimizations when you don't want to debug but simply use your app. best regards marcus Tuesday, July 11, 2006, 5:21:09 PM, you wrote: > Antony Dovgal wrote: >> On 11.07.2006 14:38, Lukas Smith wrote: >>> Michael Wallner wrote: >>> - error

Re: [PHP-DEV] Re: More valuable error message handling

2006-07-11 Thread Michael Vergoz
Hi Mike For me +1 :) I just have to look at something because i found a mem-leak where you patch (near) I will write a mail soon Mv- -Original Message - From: "Michael Wallner" <[EMAIL PROTECTED]> To: Sent: Tuesday, July 11, 2006 4:53 PM Subject: [PHP-DEV] Re: Mor

Re: [PHP-DEV] Re: More valuable error message handling

2006-07-11 Thread Michael Wallner
Antony Dovgal wrote: On 11.07.2006 14:38, Lukas Smith wrote: Michael Wallner wrote: - error_get_last() Get the last error message. my wish would be that this one should work even if track_errors is not enabled. Yes, these functions should not depend on any INI directives. I'm with Ilia

[PHP-DEV] Re: More valuable error message handling

2006-07-11 Thread Michael Wallner
I wrote: I therefore propose some new functionality with possibly this 3 new functions: - error_get_last() Get the last error message. - error_get_all() Get an array of all occurred errors. - error_clear_all() Reset error stack. Patch against 5_2: http://dev.iworks.at/PATCHES/errorstack.dif

Re: [PHP-DEV] Re: More valuable error message handling

2006-07-11 Thread Antony Dovgal
On 11.07.2006 14:38, Lukas Smith wrote: Michael Wallner wrote: - error_get_last() Get the last error message. my wish would be that this one should work even if track_errors is not enabled. Yes, these functions should not depend on any INI directives. -- Wbr, Antony Dovgal -- PHP Inter

[PHP-DEV] Re: More valuable error message handling

2006-07-11 Thread Lukas Smith
Michael Wallner wrote: - error_get_last() Get the last error message. my wish would be that this one should work even if track_errors is not enabled. regards, Lukas -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php