Re: [PHP-DEV] Re: JSON_THROW_ON_ERROR implementation detail

2019-06-04 Thread Nicolas Grekas
Hi, Le ven. 24 mai 2019 à 01:55, Andrea Faulds a écrit : > > Please see the discussion on the original pull request: > https://github.com/php/php-src/pull/2662 > > The existing behaviour is deliberate, was already discussed, and was > Symfony is affected too, could you please have a look at the

[PHP-DEV] Re: JSON_THROW_ON_ERROR implementation detail

2019-05-23 Thread Andrea Faulds
Hi Dan, Sorry, I think I should directly address your points. Dan Ackroyd wrote: Apparently there is an implementation detail in JSON_THROW_ON_ERROR that differs in the RFC text, from the discussion on list http://news.php.net/php.internals/100569: I decided to reset it to no error because t

[PHP-DEV] Re: JSON_THROW_ON_ERROR implementation detail

2019-05-23 Thread Andrea Faulds
Hi Dan, Please see the discussion on the original pull request: https://github.com/php/php-src/pull/2662 The existing behaviour is deliberate, was already discussed, and was part of the RFC that was accepted. So there is a high standard to meet for going back on that. The idea was to keep