Re: [PHP-DEV] Re: Improvements to array.c code base

2015-02-01 Thread Benjamin Coutu
ly the way to go. Thanks, Ben == Original == From: Dmitry Stogov To: Benjamin Coutu Date: Mon, 02 Feb 2015 06:53:20 +0100 Subject: [PHP-DEV] Re: Improvements to array.c code base Hi Benjamin, We are in the state, when we mainly have to concentrate on big improvements that

[PHP-DEV] Re: Improvements to array.c code base

2015-02-01 Thread Dmitry Stogov
Hi Benjamin, We are in the state, when we mainly have to concentrate on big improvements that we have to deliver till mid of March. I keep your ideas, but they are stuck at the end of my TODO list. Thanks. Dmitry. On Tue, Jan 20, 2015 at 11:30 AM, Benjamin Coutu wrote: > Hi Dmitry, > > I was

Re: [PHP-DEV] Re: Improvements to array.c code base

2015-01-20 Thread Xinchen Hui
To: Benjamin Coutu > Date: Tue, 20 Jan 2015 10:13:04 +0100 > Subject: Re: [PHP-DEV] Re: Improvements to array.c code base > > > > Hey: > > On Tue, Jan 20, 2015 at 5:06 PM, Benjamin Coutu wrote: >> Hi, >> >> Regarding ARRAY_SLICE(..., preserve_keys=fals

Re: [PHP-DEV] Re: Improvements to array.c code base

2015-01-20 Thread Benjamin Coutu
Sorry, your right of course as not preserving keys only applies to numeric indices. == Original == From: Xinchen Hui To: Benjamin Coutu Date: Tue, 20 Jan 2015 10:13:04 +0100 Subject: Re: [PHP-DEV] Re: Improvements to array.c code base Hey: On Tue, Jan 20, 2015 at 5:06 PM

Re: [PHP-DEV] Re: Improvements to array.c code base

2015-01-20 Thread Xinchen Hui
rd libraries? Is there some particular drawback? I'd like to > understand. hmm, https://wiki.php.net/rfc/fast_zpp :) thanks > > Thanks, > > Ben > > == Original == > From: Xinchen Hui > To: Benjamin Coutu > Date: Tue, 20 Jan 2015 09:53:38 +0100 > Sub

Re: [PHP-DEV] Re: Improvements to array.c code base

2015-01-20 Thread Benjamin Coutu
FAST_ZPP: Why is it not used more often, especially in the satndard libraries? Is there some particular drawback? I'd like to understand. Thanks, Ben == Original == From: Xinchen Hui To: Benjamin Coutu Date: Tue, 20 Jan 2015 09:53:38 +0100 Subject: [PHP-DEV] Re: Improvemen

[PHP-DEV] Re: Improvements to array.c code base

2015-01-20 Thread Xinchen Hui
Hey: On Tue, Jan 20, 2015 at 4:30 PM, Benjamin Coutu wrote: > Hi Dmitry, > > I was doing some code review of ext/standard/array.c and have recognized some > potential for a few performance improvements: > > === ARRAY_SLICE(..., preserve_keys=false) === > > array_slice() can always construct a p