Re: [PHP-DEV] Re: HTTP/1.1 by default in PHP 8.0

2020-07-28 Thread Rowan Tommins
On 28/07/2020 19:22, Niklas Keller wrote: Do we handle 1XX responses, yet? https://tools.ietf.org/html/rfc7231#section-6.2 Yes, as of this patch a few years back: https://github.com/php/php-src/pull/2175/files This is what implementations should do, see https://tools.ietf.org/html/rfc72

Re: [PHP-DEV] Re: HTTP/1.1 by default in PHP 8.0

2020-07-28 Thread Niklas Keller
Hey all, > > > Given that it's a very small change, the RFC is probably not necessary, > in > > which case it's not too late, however I'd like some clarification about > > what this actually offers over defaulting to 1.0. > One thing it offers is detecting truncated responses. Servers will often

Re: [PHP-DEV] Re: HTTP/1.1 by default in PHP 8.0

2020-07-28 Thread Sara Golemon
On Tue, Jul 28, 2020 at 3:52 AM Rowan Tommins wrote: > The risk of advertising 1.0 by default is that some software will have been > programmed to outright refuse that protocol version. I don't know of any > recent examples, but this bug report from 2007 was for a SOAP endpoint that > returned 50

Re: [PHP-DEV] Re: HTTP/1.1 by default in PHP 8.0

2020-07-28 Thread Björn Larsson
Hi Rowan, Den 2020-07-28 kl. 10:52, skrev Rowan Tommins: Hi Sara, On Tue, 28 Jul 2020 at 00:24, Sara Golemon wrote: Given that it's a very small change, the RFC is probably not necessary, in which case it's not too late, however I'd like some clarification about what this actually offers ov

Re: [PHP-DEV] Re: HTTP/1.1 by default in PHP 8.0

2020-07-28 Thread Rowan Tommins
On Tue, 28 Jul 2020 at 10:13, Eliot Lear wrote: > I think this is ok for a client. I'd feel differently about servers. > There may be other subtle changes between 1.0 and 1.1. Have you > reviewed those? > I did my best; see previous mails in this thread for my analysis. It's surprisingly hard

Re: [PHP-DEV] Re: HTTP/1.1 by default in PHP 8.0

2020-07-28 Thread Rowan Tommins
Hi Sara, On Tue, 28 Jul 2020 at 00:24, Sara Golemon wrote: > > Given that it's a very small change, the RFC is probably not necessary, in > which case it's not too late, however I'd like some clarification about > what this actually offers over defaulting to 1.0. > That's a very reasonable que

Re: [PHP-DEV] Re: HTTP/1.1 by default in PHP 8.0

2020-07-27 Thread Sara Golemon
On Mon, Jul 27, 2020 at 5:25 PM Rowan Tommins wrote: > A couple of months ago I revived my suggestion to make stream wrappers > advertise HTTP/1.1 by default (full message below), and then Real Life > intervened and I didn't raise the PR. > > The implementation (which is a one-character change) i

[PHP-DEV] Re: HTTP/1.1 by default in PHP 8.0

2020-07-27 Thread Rowan Tommins
Hi all, A couple of months ago I revived my suggestion to make stream wrappers advertise HTTP/1.1 by default (full message below), and then Real Life intervened and I didn't raise the PR. The implementation (which is a one-character change) is now here: https://github.com/php/php-src/pull/58