Felipe Pena wrote:
Hello,
just to inform, I've commited (yesterday) the patch removing the
UG(unicode) checks, etc across all source (except mysql exts). As the
patch has 492K, looks as no mail will be sent.
I'd given up hope of ever seeing that reach CVS :)
Thanks Felipe!
- Steph
--
PHP In
2009/3/27 Sebastian Bergmann :
> Felipe Pena schrieb:
>> + - Removed:
>> + - UG(unicode) checks
>> + - pcre_cache_entry.unicode_mode
>> + - Changed:
>> + - ZEND_STR_TYPE -> IS_UNICODE
>> + - convert_to_text -> convert_to_unicode
>> +
Felipe Pena schrieb:
> + - Removed:
> + - UG(unicode) checks
> + - pcre_cache_entry.unicode_mode
> + - Changed:
> + - ZEND_STR_TYPE -> IS_UNICODE
> + - convert_to_text -> convert_to_unicode
> + - convert_to_text_ex -> convert_to_
David Coallier wrote:
> 2009/3/27 Hannes Magnusson :
>> 2009/3/27 Felipe Pena :
>>> Hello,
>>> just to inform, I've commited (yesterday) the patch removing the
>>> UG(unicode) checks, etc across all source (except mysql exts). As the
>>> patch has 492K, looks as no mail will be sent.
>> [...]
>
>
2009/3/27 Hannes Magnusson :
> 2009/3/27 Felipe Pena :
>> Hello,
>> just to inform, I've commited (yesterday) the patch removing the
>> UG(unicode) checks, etc across all source (except mysql exts). As the
>> patch has 492K, looks as no mail will be sent.
> [...]
Would you mind letting the list kn
2009/3/27 Felipe Pena :
> Hello,
> just to inform, I've commited (yesterday) the patch removing the
> UG(unicode) checks, etc across all source (except mysql exts). As the
> patch has 492K, looks as no mail will be sent.
[...]
> + (Felipe, Steph)
Kudos!!
-Hannes
--
PHP Internals - PHP Runti
Hello,
just to inform, I've commited (yesterday) the patch removing the
UG(unicode) checks, etc across all source (except mysql exts). As the
patch has 492K, looks as no mail will be sent.
+* ZendEngine2/zend.c
+ ZendEngine2/zend.h
+ ZendEngine2/zend_API.c
+ ZendEngine2/zend_API
Yes, good idea. PRE-BFUC (PRE-BigFreakingUnicodeCleanup)
-Andrei
Stanislav Malyshev wrote:
Hi!
Oh, and third - if nobody gets back to us by Friday over these patches
we'll just commit :) Don't know about Felipe's larger corner, but I
tested mine to death already.
I think it would also be n
I'm working on the patch to remove stuff from Zend/*, I've yet to change
any of the macros. Will most likely leave that to last.
Scott
Stanislav Malyshev wrote:
- Changed:
- ZEND_STR_TYPE -> IS_UNICODE
- convert_to_text -> convert_to_unicode
- convert_to_text_ex -> convert
Hi Stas,
- Changed:
- ZEND_STR_TYPE -> IS_UNICODE
- convert_to_text -> convert_to_unicode
- convert_to_text_ex -> convert_to_unicode_ex
Would the cleanup include the engine - i.e. all the UG-ly stuff in
macros, functions, etc. - or only ext/* part?
Scott's working on t
- Changed:
- ZEND_STR_TYPE -> IS_UNICODE
- convert_to_text -> convert_to_unicode
- convert_to_text_ex -> convert_to_unicode_ex
Would the cleanup include the engine - i.e. all the UG-ly stuff in
macros, functions, etc. - or only ext/* part?
--
Stanislav Malyshev, Zend Softw
Oh, and third - if nobody gets back to us by Friday over these patches
we'll just commit :) Don't know about Felipe's larger corner, but I
tested mine to death already.
I think it would also be nice to tag it before the change, just in case.
Oooh, exciting stuff :)
- Steph
--
Stanislav M
On 10.06.2008 11:04, Stanislav Malyshev wrote:
Hi!
Oh, and third - if nobody gets back to us by Friday over these patches
we'll just commit :) Don't know about Felipe's larger corner, but I
tested mine to death already.
I think it would also be nice to tag it before the change, just in case.
Hi!
Oh, and third - if nobody gets back to us by Friday over these patches
we'll just commit :) Don't know about Felipe's larger corner, but I
tested mine to death already.
I think it would also be nice to tag it before the change, just in case.
--
Stanislav Malyshev, Zend Software Architect
t;[EMAIL PROTECTED]>
Cc: "Andrei Zmievski" <[EMAIL PROTECTED]>; "internals"
Sent: Monday, June 09, 2008 7:49 PM
Subject: Re: [PHP-DEV] Re: Focus on HEAD
Hi all
Em Seg, 2008-06-09 às 18:55 +0100, Steph Fox escreveu:
Hi all,
Andrei doesn't have time to review this lot
Hi all
Em Seg, 2008-06-09 às 18:55 +0100, Steph Fox escreveu:
> Hi all,
>
> Andrei doesn't have time to review this lot (covers ext/standard). Could
> someone please check it for clangers?
>
> Thanks,
>
> - Steph
Here's the rest (ext/* and main/*):
http://felipe.ath.cx/diff/unicode-check.diff
Sure.
Steph Fox wrote:
Is there a patch that does that? I'm fine with removing these checks.
If there isn't already, there soon will be :)
Did you want to review it prior to commit?
- Steph
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.ne
Is there a patch that does that? I'm fine with removing these checks.
If there isn't already, there soon will be :)
Did you want to review it prior to commit?
- Steph
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Is there a patch that does that? I'm fine with removing these checks.
-Andrei
Steph Fox wrote:
Hi Andrei, all,
Can we please have a clear, on-list explanation of the reason(s) the
non-Unicode mode blocks can't be cleared out of core in CVS HEAD today?
As in, if (!UG(unicode))
Thanks
19 matches
Mail list logo
