Hey:
On Thu, Jan 15, 2015 at 7:52 AM, Pierre Joye wrote:
> On Wed, Jan 14, 2015 at 9:09 PM, Stanislav Malyshev
> wrote:
>> Hi!
>>
>>> I made a PR here: https://github.com/php/php-src/pull/999 for reviewing
>>>
>>> in benchmark this can brings more than 30% performance gain in
>>> arra
On Wed, Jan 14, 2015 at 9:09 PM, Stanislav Malyshev wrote:
> Hi!
>
>> I made a PR here: https://github.com/php/php-src/pull/999 for reviewing
>>
>> in benchmark this can brings more than 30% performance gain in
>> array_sort etc functions.
>>
>> tests fails are related to non-stable vs
Hi!
> I made a PR here: https://github.com/php/php-src/pull/999 for reviewing
>
> in benchmark this can brings more than 30% performance gain in
> array_sort etc functions.
>
> tests fails are related to non-stable vs stable sorting difference.
>
> anyway, I feel it's better to
I don't see big problems committing this.
In some cases new sort() functions may provide different results, but they
are still valid, because the order of "equal" elements after sort is not
defined.
Thanks. Dmitry.
On Wed, Jan 14, 2015 at 12:59 PM, Xinchen Hui wrote:
> Hey:
>
> I made a PR
Hey:
I made a PR here: https://github.com/php/php-src/pull/999 for reviewing
in benchmark this can brings more than 30% performance gain in
array_sort etc functions.
tests fails are related to non-stable vs stable sorting difference.
anyway, I feel it's better to ask you to do a
I think this break is acceptable
Of course, if the new sort implementation significantly improves
performance on some cases and doesn't show degradation on the others.
Thanks. Dmitry.
On Jan 5, 2015 9:08 PM, "Xinchen Hui" wrote:
> Hey:
>
> I was working on zend_qsort improvement. but I got
Sounds more like a bugfix to me and def'ly an acceptable BC break in
either case. The behavior isn't specified and if anything I would
assume there _wouldn't_ be a swap with SORT_FLAG_CASE on. Interesting
though that many sorting examples (across languages) sidestep this
clearly common case.
-- S.
Hey：
> On Jan 6, 2015, at 1:27 AM, Julien Pauli wrote:
>
>> On Mon, Jan 5, 2015 at 6:09 PM, Xinchen Hui wrote:
>> On Tue, Jan 6, 2015 at 1:08 AM, Xinchen Hui wrote:
>> > Hey:
>> >
>> > I was working on zend_qsort improvement. but I got a problem need
>> > to be disscussed with you fist..
On Mon, Jan 5, 2015 at 6:09 PM, Xinchen Hui wrote:
> On Tue, Jan 6, 2015 at 1:08 AM, Xinchen Hui wrote:
> > Hey:
> >
> > I was working on zend_qsort improvement. but I got a problem need
> > to be disscussed with you fist..
> first
> >
> > as we know, previously zend_qsort is not a st
On Tue, Jan 6, 2015 at 1:08 AM, Xinchen Hui wrote:
> Hey:
>
> I was working on zend_qsort improvement. but I got a problem need
> to be disscussed with you fist..
first
>
> as we know, previously zend_qsort is not a stable sorting algo.
>
> my draft patch (which already get 0.1% IR
10 matches
Mail list logo
