Re: [PHP-DEV] Re: Fast zend_parse_parameters API

2014-09-05 Thread Dmitry Stogov
no. Dmitry. On Fri, Sep 5, 2014 at 12:14 PM, Pierre Joye wrote: > On Fri, Sep 5, 2014 at 9:40 AM, Dmitry Stogov wrote: > > most of the functions converted to FAST_ZPP were collected by profiling > or > > real life apps. > > These functions spent significant part of the time in > > zend_parse_

Re: [PHP-DEV] Re: Fast zend_parse_parameters API

2014-09-05 Thread Pierre Joye
On Fri, Sep 5, 2014 at 9:40 AM, Dmitry Stogov wrote: > most of the functions converted to FAST_ZPP were collected by profiling or > real life apps. > These functions spent significant part of the time in > zend_parse_parameters() because they are short themselves or because they > are called very

Re: [PHP-DEV] Re: Fast zend_parse_parameters API

2014-09-05 Thread Dmitry Stogov
most of the functions converted to FAST_ZPP were collected by profiling or real life apps. These functions spent significant part of the time in zend_parse_parameters() because they are short themselves or because they are called very often. few functions were added to test some "exotic" type spec

Re: [PHP-DEV] Re: Fast zend_parse_parameters API

2014-09-05 Thread Pierre Joye
On Fri, Sep 5, 2014 at 8:45 AM, Dmitry Stogov wrote: > It's already done for strlen() - ZEND_STRLEN opcode (and few other > functions). > But it make no sense to convert all useful functions into opcodes. > We need an ability of fast parameter parsing anyway. Got that, but hard to say for which f

Re: [PHP-DEV] Re: Fast zend_parse_parameters API

2014-09-04 Thread Dmitry Stogov
It's already done for strlen() - ZEND_STRLEN opcode (and few other functions). But it make no sense to convert all useful functions into opcodes. We need an ability of fast parameter parsing anyway. Thanks. Dmitry. On Fri, Sep 5, 2014 at 5:55 AM, Stas Malyshev wrote: > Hi! > > > As I understa

Re: [PHP-DEV] Re: Fast zend_parse_parameters API

2014-09-04 Thread Stas Malyshev
Hi! > As I understand correctly the only reason we have this discussion is > the performance impact of zpp with some functions, mainly > ZEND_FUNCTIONs. What prevents us to make them operators? That may > break things like call_user_func("strlen", $arg), array_map and the There's also an issue t

Re: [PHP-DEV] Re: Fast zend_parse_parameters API

2014-09-04 Thread Pierre Joye
On Thu, Sep 4, 2014 at 3:56 PM, Dmitry Stogov wrote: > I like the idea of having a single syntax for all cases, but I don't like > the syntax you propose. > In my opinion, it's syntactically inconsistent, less readable and more > error prone, than the old one (sscanf based) and the FAST_ZPP one th

[PHP-DEV] Re: Fast zend_parse_parameters API

2014-09-04 Thread Dmitry Stogov
I like the idea of having a single syntax for all cases, but I don't like the syntax you propose. In my opinion, it's syntactically inconsistent, less readable and more error prone, than the old one (sscanf based) and the FAST_ZPP one that is already in php-master. I would also prefer to have an a