Re: [PHP-DEV] Re: Changing the generated name for anon classes

2020-03-04 Thread Niklas Keller
Hi Nikita, while we're changing the naming scheme, could we also get rid of the NUL byte, please? Binary in logs due to things like get_class really isn't that nice. Regarding checking whether something is an anonymous class, how about adding a function to check whether a class name is an anonymo

Re: [PHP-DEV] Re: Changing the generated name for anon classes

2020-02-13 Thread Nikita Popov
On Fri, Feb 7, 2020 at 2:35 PM Nikita Popov wrote: > On Thu, Feb 6, 2020 at 9:08 PM Andrea Faulds wrote: > >> Hi, >> >> Nikita Popov wrote: >> > Hi internals, >> > >> > Based on a suggestion by Nicolas Grekas, >> > https://github.com/php/php-src/pull/5153 changes the generated name for >> > anon

Re: [PHP-DEV] Re: Changing the generated name for anon classes

2020-02-07 Thread Nicolas Grekas
Le ven. 7 févr. 2020 à 14:36, Nikita Popov a écrit : > On Thu, Feb 6, 2020 at 9:08 PM Andrea Faulds wrote: > >> Hi, >> >> Nikita Popov wrote: >> > Hi internals, >> > >> > Based on a suggestion by Nicolas Grekas, >> > https://github.com/php/php-src/pull/5153 changes the generated name for >> > an

Re: [PHP-DEV] Re: Changing the generated name for anon classes

2020-02-07 Thread Nikita Popov
On Thu, Feb 6, 2020 at 9:08 PM Andrea Faulds wrote: > Hi, > > Nikita Popov wrote: > > Hi internals, > > > > Based on a suggestion by Nicolas Grekas, > > https://github.com/php/php-src/pull/5153 changes the generated name for > > anonymous classes to include the name of the parent class or first >

[PHP-DEV] Re: Changing the generated name for anon classes

2020-02-06 Thread Andrea Faulds
Hi, Nikita Popov wrote: Hi internals, Based on a suggestion by Nicolas Grekas, https://github.com/php/php-src/pull/5153 changes the generated name for anonymous classes to include the name of the parent class or first interface. So instead of just class@anonymous, you'll see something like Even