[PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c php-src NEWS

2005-10-31 Thread Sebastian Bergmann
Dmitry Stogov schrieb: > Yes. But with Sebastian's patch object is stored in bactrace. > So refcount is more then 1 and we cannot simple destroy it. Would it help to move the functionality I need from debug_backtrace() into a new function or make it optional in debug_backtrace()? -- Sebastian

[PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c php-src NEWS

2005-10-31 Thread Sebastian Bergmann
Dmitry Stogov schrieb: > Of course we can. :) Go ahead and commit it if the current implementation breaks things. > But probably $this can be really useful in debug backtrace. I just hope that this feature can be preserved, whether or not based upon my 5-minute-patch is secondary ;-) -- Seb

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c php-src NEWS

2005-10-29 Thread Sebastian Bergmann
Marcus Boerger schrieb: > what do you think comes out first, 5.1.1 or 6.0 ? PHP 5.1.1, of course. But as I cannot yet commit to PHP_5_1 I did not want to have the patch in HEAD without a NEWS entry. -- Sebastian Bergmann http://www.sebastian-bergmann.de/ GnuPG Key: 0xB85B5

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c php-src NEWS

2005-10-29 Thread Marcus Boerger
Hello Sebastian, what do you think comes out first, 5.1.1 or 6.0 ? marcus Saturday, October 29, 2005, 12:36:04 PM, you wrote: > Jani Taskinen schrieb: >> If you're going to add it in PHP_5_1 branch, >> why are you adding the thing in HEAD NEWS file? > Because for now it is in HEAD only. Once

[PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c php-src NEWS

2005-10-29 Thread Sebastian Bergmann
Jani Taskinen schrieb: > If you're going to add it in PHP_5_1 branch, > why are you adding the thing in HEAD NEWS file? Because for now it is in HEAD only. Once PHP 5.1.0 has been released and the PHP_5_1 branch is open for this kind of check-in, I will MFH the patch from HEAD and move the NEWS

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c

2005-04-10 Thread Marcus Boerger
Hello Zeev, stay tuned, i'll take care of that after discussing with Andi where to put those stuff. best regards marcus Sunday, April 10, 2005, 10:45:23 PM, you wrote: > I think Andi hit the nail right on the head. > PHP was never about perfection, it was and should continue to be about > g

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c

2005-04-10 Thread Zeev Suraski
I think Andi hit the nail right on the head. PHP was never about perfection, it was and should continue to be about getting things done. So having X_exists() doesn't immediately mean we also have _exists() methods for Y and Z too, especially if they go against guidelines which we've established

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c

2005-04-08 Thread Andrey Hristov
Hi Andi, no problem of being sarcastic ;) After this discussion has started I decided not to implement this class_constant_exists() because I just want to leave our function API incomplete :P. Now seriously, I have no problem, I took the errand just to exercise myself and I will not advocate th

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c

2005-04-08 Thread Marcus Boerger
Hello Andi, Saturday, April 9, 2005, 1:10:12 AM, you wrote: > Marcus, > PHP is being used by millions of people and it is irrelevant whether you > think that const was wrong from the beginning or not, because we won't fix > something which has been around probably since 1995. Restating that ove

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c

2005-04-08 Thread Andi Gutmans
Guess what. I've already cooked it up for you! (OK so I didn't write the code but...) /* {{{ proto public bool ReflectionClass::hasConstant(string name) Returns wether a constant exists or not */ Now if it really is too much for you to write then with 4 lines of code you can create your own c

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c

2005-04-08 Thread Andi Gutmans
Marcus, PHP is being used by millions of people and it is irrelevant whether you think that const was wrong from the beginning or not, because we won't fix something which has been around probably since 1995. Restating that over and over is not productive as we should support what has been aroun

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c

2005-04-08 Thread Marcus Boerger
Hello Andi, erm yes i could put it to spl as a convenience function prefixed by 'spl_' and we could also add a namespace for class functions 'class_' or one for the reflection api (whatever that might be) or we could put those as static methods into class 'Reflection'. However all of these makee

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c

2005-04-08 Thread Andi Gutmans
It's vital? Come on, you can convince me that it's nice to have, sure. But vital? What can it do which you can do with reflection API? If the name is sexier than you can write your own PHP function. At 06:36 PM 4/8/2005 +0200, Marcus Boerger wrote: Hello Andrey, same goes for property_exists()

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c

2005-04-08 Thread Andi Gutmans
At 06:31 PM 4/8/2005 +0200, Andrey Hristov wrote: Hello Andi, Marcus, method_exists() is quite vital to help where the type hinting fail. Type hinting fail because it leads to a fatal error which is uncatchable and the code cannot react on this. Therefore, for me type hinting is kind of useless s

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c

2005-04-08 Thread Andi Gutmans
At 06:14 PM 4/8/2005 +0200, Marcus Boerger wrote: Hello Andi, to this i only agree under two conditions. First we remove other like method_exists() too and second we fix handling of implicit public and dynamic properties. Unless the second is done i see such a function as relative important and d

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c

2005-04-08 Thread Marcus Boerger
Hello Andrey, same goes for property_exists() which is why i added it. marcus Friday, April 8, 2005, 6:31:48 PM, you wrote: >Hello Andi, Marcus, > method_exists() is quite vital to help where the type hinting fail. > Type hinting fail because it leads to a fatal error which is uncatchable

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c

2005-04-08 Thread Andrey Hristov
Hello Andi, Marcus, method_exists() is quite vital to help where the type hinting fail. Type hinting fail because it leads to a fatal error which is uncatchable and the code cannot react on this. Therefore, for me type hinting is kind of useless since I cannot catch my bugs by executing some code

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c

2005-04-08 Thread Marcus Boerger
Hello Andi, to this i only agree under two conditions. First we remove other like method_exists() too and second we fix handling of implicit public and dynamic properties. Unless the second is done i see such a function as relative important and don't like to use reflection overhead always. reg

[PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c

2005-04-08 Thread Andi Gutmans
Marcus, There was a long discussion about this a few months ago. The conclusion was to use the reflection_api for the very few instances where isset() isn't relevant. Although we have done bad stuff in the past, it's also not a good idea to continue polluting the global namespace. Please revert t

[PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c

2005-04-08 Thread Lukas Smith
Andrey Hristov wrote: Hi Marcus, what about class_constant_exists("classname", "const") (a bit long function name though)? maybe leave of the ant ... class_const_exists() fits in with class MyClass { const constant = 'constant value'; function showConstant() { echo self::constant .

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c

2005-04-08 Thread Andrey Hristov
Hello Marcus, ok, I will try to cook up something but this time I won't be so fast since I have some pending commercial :) stuff. Andrey Marcus Boerger wrote: Hello Andrey, somehow i knew someone would ask for that how about you writing a patch? Friday, April 8, 2005, 5:01:24 PM, you wrote

Re: [PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c

2005-04-08 Thread Marcus Boerger
Hello Andrey, somehow i knew someone would ask for that how about you writing a patch? Friday, April 8, 2005, 5:01:24 PM, you wrote: >Hi Marcus, > what about class_constant_exists("classname", "const") > (a bit long function name though)? > Andrey > Marcus Boerger wrote: >> helly

[PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c

2005-04-08 Thread Andrey Hristov
Hi Marcus, what about class_constant_exists("classname", "const") (a bit long function name though)? Andrey Marcus Boerger wrote: helly Fri Apr 8 09:33:17 2005 EDT Modified files: /ZendEngine2 zend_builtin_functions.c Log: - Add property_exits() http://cvs.p

[PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c

2004-01-10 Thread Christian Schneider
Sebastian Bergmann wrote: Log: Added error mask to set_error_handler() Patch by Christian Schneider <[EMAIL PROTECTED]> zend_operators.c e:\home\php\php5\zend\zend_operators.c(36) : error C2059: Syntaxfehler : '<<' To avoid misinterpretation: My patch didn't involve zend_operators.c, that was a

[PHP-DEV] Re: [ZEND-ENGINE-CVS] cvs: ZendEngine2 / zend_builtin_functions.c zend_execute_API.c zend_globals.h zend_operators.c

2004-01-10 Thread Sebastian Bergmann
Zeev Suraski wrote: > zeev Sat Jan 10 06:43:42 2004 EDT > > Modified files: > /ZendEngine2 zend_builtin_functions.c zend_execute_API.c > zend_globals.h zend_operators.c > Log: > Added error mask to set_error_handler() > Patch by Christian Schneider <[