Re: [PHP-DEV] Re: [Request][Discussion] Double value as array key improvement

On Thu, Aug 31, 2017 at 2:58 AM Andrea Faulds wrote: > Hi there, > > Andrew Nester wrote: > > > > > > Hello internals! > > > > I was working on solution for the problem of double to int conversion > for array indices and would like to create an RFC for proposed solution - > emitting warning when

[PHP-DEV] Re: [Request][Discussion] Double value as array key improvement

Hi there, Andrew Nester wrote: Hello internals! I was working on solution for the problem of double to int conversion for array indices and would like to create an RFC for proposed solution - emitting warning when integer overflow happens during double to int conversion. Does it look like

Re: [PHP-DEV] Re: [Request][Discussion] Double value as array key improvement

> On Aug 19, 2017, at 4:30 PM, Nikita Popov wrote: > > On Thu, Aug 17, 2017 at 5:03 PM, Andrew Nester > wrote: > > > > 13 авг. 2017 г., в 21:39, Andrew Nester > > написал(а): > > > > > > > >> 11 авг. 2017 г., в 15:53, An

Re: [PHP-DEV] Re: [Request][Discussion] Double value as array key improvement

Hi everyone, Nikita Popov wrote: Sounds good to me. Something you might want to consider is to also throw a warning if the floating point number is not an exact integer. For example allow a silent cast of 42.0 to 42, but throw a warning if 42.5 is used as an index (or worse, 42.9, in wh

Re: [PHP-DEV] Re: [Request][Discussion] Double value as array key improvement

On Thu, Aug 17, 2017 at 5:03 PM, Andrew Nester wrote: > > > > 13 авг. 2017 г., в 21:39, Andrew Nester > написал(а): > > > > > > > >> 11 авг. 2017 г., в 15:53, Andrew Nester написал(а): > >> > >> > >>> On Aug 11, 2017, at 2:10 PM, Andrew Nester wrote: > >>> > >>> Hello everyone! > >>> > >>> I w

Re: [PHP-DEV] Re: [Request][Discussion] Double value as array key improvement

Just reposting to internals: David wrote: > If the key is user dependent (eg. Input from form), could it causes a warning too, right? I think that it should be considered a BC. Andrew Nester wrote: > Yes, warning will be emitted in this case as well but actual index will remain the same. > I coul

[PHP-DEV] Re: [Request][Discussion] Double value as array key improvement

> 13 авг. 2017 г., в 21:39, Andrew Nester > написал(а): > > > >> 11 авг. 2017 г., в 15:53, Andrew Nester написал(а): >> >> >>> On Aug 11, 2017, at 2:10 PM, Andrew Nester wrote: >>> >>> Hello everyone! >>> >>> I was working on following request https://bugs.php.net/bug.php?id=75053 >>>

[PHP-DEV] Re: [Request][Discussion] Double value as array key improvement

On 13.08.2017 at 20:39, Andrew Nester wrote: > 11 авг. 2017 г., в 15:53, Andrew Nester написал(а): > >> Here is the alternative solution which emits E_WARNING in case of integer >> array index overflow. >> https://github.com/php/php-src/pull/2677 > > My preferred solution is 2nd one (emitting w

[PHP-DEV] Re: [Request][Discussion] Double value as array key improvement

> 11 авг. 2017 г., в 15:53, Andrew Nester написал(а): > > >> On Aug 11, 2017, at 2:10 PM, Andrew Nester wrote: >> >> Hello everyone! >> >> I was working on following request https://bugs.php.net/bug.php?id=75053 >> which resulted in following pull request >> https://github.com/php/php-src

[PHP-DEV] Re: [Request][Discussion] Double value as array key improvement

> 11 авг. 2017 г., в 15:53, Andrew Nester написал(а): > > >> On Aug 11, 2017, at 2:10 PM, Andrew Nester wrote: >> >> Hello everyone! >> >> I was working on following request https://bugs.php.net/bug.php?id=75053 >> which resulted in following pull request >> https://github.com/php/php-src

[PHP-DEV] Re: [Request][Discussion] Double value as array key improvement

> On Aug 11, 2017, at 2:10 PM, Andrew Nester wrote: > > Hello everyone! > > I was working on following request https://bugs.php.net/bug.php?id=75053 > which resulted in following pull > request https://github.com/php/php-src/pull/2676 >