[PHP-DEV] Re: [RFC] Reclassifying engine warnings

2019-09-15 Thread Mark Randall
On 28/08/2019 10:33, Nikita Popov wrote: https://wiki.php.net/rfc/engine_warnings I am 100% behind the exception proposals, however I did want to discuss the warnings. I am personally of the belief that there should be a distinction made between notices / warnings issued by the engine, and

Re: [PHP-DEV] Re: [RFC] Reclassifying engine warnings

2019-09-10 Thread Björn Larsson
Den 2019-09-10 kl. 15:31, skrev Nikita Popov: On Wed, Aug 28, 2019 at 11:33 AM Nikita Popov wrote: Hi internals, I think it's time to take a look at our existing warnings & notices in the engine, and think about whether their current classification is still appropriate. Error conditions like

[PHP-DEV] Re: [RFC] Reclassifying engine warnings

2019-09-10 Thread Nikita Popov
On Wed, Aug 28, 2019 at 11:33 AM Nikita Popov wrote: > Hi internals, > > I think it's time to take a look at our existing warnings & notices in the > engine, and think about whether their current classification is still > appropriate. Error conditions like "undefined variable" only generating a >

Re: [PHP-DEV] Re: [RFC] Reclassifying engine warnings

2019-08-29 Thread Aegir Leet via internals
I'm sorry, but if you seriously believe doing something that generates a notice (or warning, or error, ...) is not a bug - you're delusional. That is the very definition of a bug and notices/warnings/errors etc. are the mechanism the language uses to report these bugs to the developer. If doing

Re: [PHP-DEV] Re: [RFC] Reclassifying engine warnings

2019-08-28 Thread Zeev Suraski
On Wed, Aug 28, 2019 at 10:26 PM Nikita Popov wrote: > On Wed, Aug 28, 2019 at 11:33 AM Nikita Popov > wrote: > > Reading this discussion has been disappointing and somewhat disillusioning. > I can understand and appreciate the concern for legacy code. But seeing the > use of undefined variables

[PHP-DEV] Re: [RFC] Reclassifying engine warnings

2019-08-28 Thread Nikita Popov
On Wed, Aug 28, 2019 at 11:33 AM Nikita Popov wrote: > Hi internals, > > I think it's time to take a look at our existing warnings & notices in the > engine, and think about whether their current classification is still > appropriate. Error conditions like "undefined variable" only generating a >

[PHP-DEV] Re: [RFC] Reclassifying engine warnings

2019-08-28 Thread Mark Randall
On 28/08/2019 10:33, Nikita Popov wrote: Hi internals, https://wiki.php.net/rfc/engine_warnings This is an absolutely outstanding move and I certainly hope it gets passed unanimously. PHP as a whole has traditionally been a language that is insanely forgiving of errors, in many cases allowi