On Wed, 29 May 2019 at 17:48, Theodore Brown wrote:
> On Wed, May 29, 2019 at 6:34 AM G. P. B. wrote:
>
> > I share the same concerns as Rowan Collins
>
> From my reading of Rowan's email, he was making a general point that
> new features can have a cost of added complexity for users. He then
>
On Tue, May 28, 2019 at 9:10 AM Theodore Brown wrote:
> > As requested at the end of April, [1] Bishop and I are resurrecting
> > the Numeric Literal Separator RFC:
> > https://wiki.php.net/rfc/numeric_literal_separator.
> >
> > If no serious issues come up, voting will start in two weeks
> > (on
On Wed, 29 May 2019 at 12:35, G. P. B. wrote:
>
> Also I think those kind of magic numbers should be constants with
> meaningful names, and it that case you could just compute them by adding
> powers of ten.
> E.g. DISCOUNT_IN_CENTS = 1 * 10^5 + 3 * 10^4 + 5 * 10^3;
I agree naming things is impor
On Wed, May 29, 2019 at 9:03 AM Côme Chilliet wrote:
> > My understanding from the RFC is that that the grouping is not
> > relevant, the `_` is stripped regardless.
> >
> > Am I wrong?
>
> No you’re not, the RFC allows grouping as the coder wants.
>
> Which is why I think it may cause problems b
On Wed, May 29, 2019 at 6:34 AM G. P. B. wrote:
> I share the same concerns as Rowan Collins
>From my reading of Rowan's email, he was making a general point that
new features can have a cost of added complexity for users. He then
clarified "I don't personally think that applies here".
> I'm re
Le mercredi 29 mai 2019, 10:39:17 CEST Markus Fischer a écrit :
> My understanding from the RFC is that that the grouping is not relevant,
> the `_` is stripped regardless.
>
> Am I wrong?
No you’re not, the RFC allows grouping as the coder wants.
Which is why I think it may cause problems beca
On Wed, May 29, 2019 at 2:49 AM Côme Chilliet wrote:
> What bugs me with this RFC is that it seems to be mainly intended
> for grouping digits by 3, which from what I understand is cultural.
While it is expected that grouping decimal literals by 3 will be a
frequent use case, the RFC does not en
I share the same concerns as Rowan Collins, and I'm really not a fan of the
RFC in general.
Also I think those kind of magic numbers should be constants with
meaningful names, and it that case you could just compute them by adding
powers of ten.
E.g. DISCOUNT_IN_CENTS = 1 * 10^5 + 3 * 10^4 + 5 * 10
On Wed, May 29, 2019 at 5:40 PM Markus Fischer wrote:
> Hi,
>
> On 29.05.19 09:49, Côme Chilliet wrote:
> > What bugs me with this RFC is that it seems to be mainly intended for
> grouping digits by 3, which from what I understand is cultural.
> > At least some asian languages have a concept of
>
Hi,
On 29.05.19 09:49, Côme Chilliet wrote:
What bugs me with this RFC is that it seems to be mainly intended for grouping
digits by 3, which from what I understand is cultural.
At least some asian languages have a concept of
https://en.wikipedia.org/wiki/Myriad and group them by 4, at least f
On 29.05.2019 at 09:49, Côme Chilliet wrote:
> What bugs me with this RFC is that it seems to be mainly intended for
> grouping digits by 3, which from what I understand is cultural.
> At least some asian languages have a concept of
> https://en.wikipedia.org/wiki/Myriad and group them by 4, at
What bugs me with this RFC is that it seems to be mainly intended for grouping
digits by 3, which from what I understand is cultural.
At least some asian languages have a concept of
https://en.wikipedia.org/wiki/Myriad and group them by 4, at least from the
language point of view.
It does seem w
On 28/05/2019 20:24, Dan Ackroyd wrote:
I also happen to think people should only vote no if they think the
change is something that adds too much complexity to PHP's internals
for the change to be worth it
I see where you're coming from with that, but there is also a cost to
*users* in havin
On Tue, 28 May 2019 at 15:10, Theodore Brown wrote:
>
> Please let me know if you have any questions or concerns before
> voting starts.
>
Particularly if you're currently planning to vote no, but a small
change or explanation might change your vote.
I also happen to think people should only vot
On Wed, May 15, 2019 at 10:32 AM Theodore Brown wrote:
> As requested at the end of April, [1] Bishop and I are resurrecting
> the Numeric Literal Separator RFC:
> https://wiki.php.net/rfc/numeric_literal_separator.
>
> If no serious issues come up, voting will start in two weeks
> (on 2019-05-29)
15 matches
Mail list logo
