Re: [PHP-DEV] Re: [RFC] Add WeakMap

2019-12-16 Thread Dennis Birkholz
On 16.12.19 10:27, Nikita Popov wrote: On Mon, Dec 16, 2019 at 10:19 AM Dennis Birkholz wrote: On 12.12.19 18:13, Nikita Popov wrote: On Tue, Dec 10, 2019 at 12:03 PM Dennis Birkholz < p...@dennis.birkholz.biz> wrote: But my just want to repeat my main concern: buildin data structures that

Re: [PHP-DEV] Re: [RFC] Add WeakMap

2019-12-16 Thread Nikita Popov
On Mon, Dec 16, 2019 at 10:19 AM Dennis Birkholz wrote: > On 12.12.19 18:13, Nikita Popov wrote: > > On Tue, Dec 10, 2019 at 12:03 PM Dennis Birkholz < > p...@dennis.birkholz.biz> > > wrote: > >> But my just want to repeat my main concern: buildin > >> data structures that are not serializable ar

Re: [PHP-DEV] Re: [RFC] Add WeakMap

2019-12-16 Thread Dennis Birkholz
On 12.12.19 18:13, Nikita Popov wrote: On Tue, Dec 10, 2019 at 12:03 PM Dennis Birkholz wrote: But my just want to repeat my main concern: buildin data structures that are not serializable are a real problem for users that use serialization extensively. Maybe the solution to that problem is a m

Re: [PHP-DEV] Re: [RFC] Add WeakMap

2019-12-12 Thread Nikita Popov
On Tue, Dec 10, 2019 at 12:03 PM Dennis Birkholz wrote: > Hi Nikita, > > On 06.12.19 11:29, Nikita Popov wrote: > > Could you provide some context on why you think serialization support for > > WeakMap is important? As weak maps are essentially caching structures, > > serializing them doesn't see

Re: [PHP-DEV] Re: [RFC] Add WeakMap

2019-12-10 Thread Dennis Birkholz
Hi Nikita, On 06.12.19 11:29, Nikita Popov wrote: Could you provide some context on why you think serialization support for WeakMap is important? As weak maps are essentially caching structures, serializing them doesn't seem particularly useful in the first place, but when combined with the quit

Re: [PHP-DEV] Re: [RFC] Add WeakMap

2019-12-06 Thread Nikita Popov
On Thu, Dec 5, 2019 at 6:09 PM Dennis Birkholz wrote: > Hi Nikita, > > Am 04.12.19 um 19:50 schrieb Nikita Popov: > >> This RFC proposes to add a native WeakMap type for PHP 8: > >> https://wiki.php.net/rfc/weak_maps > > > > Any comments on this proposal? Otherwise this could head to voting... >

Re: [PHP-DEV] Re: [RFC] Add WeakMap

2019-12-05 Thread Dennis Birkholz
Hi Nikita, Am 04.12.19 um 19:50 schrieb Nikita Popov: >> This RFC proposes to add a native WeakMap type for PHP 8: >> https://wiki.php.net/rfc/weak_maps > > Any comments on this proposal? Otherwise this could head to voting... thanks for this proposal, will be really helpful! The only caveat for

[PHP-DEV] Re: [RFC] Add WeakMap

2019-12-04 Thread Nikita Popov
On Mon, Nov 4, 2019 at 2:22 PM Nikita Popov wrote: > Hi internals, > > This is a follow up to the addition of WeakReference in PHP 7.4. > WeakReference is an important primitive, but what people usually really > need are weak maps, which can't be implemented on top of WeakReference (at > least, n