Re: [PHP-DEV] Re: [PREVOTE] PHP Engine Constants

2016-09-06 Thread Stanislav Malyshev
Hi! > And then when the next people who want to build an alternative engine > come along, they will include this constant, to make their engine as > 'compatible' as possible with the current PHP engine. Yes, same things that happened to user-agent string in browsers may start happening here. But

Re: [PHP-DEV] Re: [PREVOTE] PHP Engine Constants

2016-09-06 Thread Davey Shafik
On Tue, Sep 6, 2016 at 2:51 PM, Dan Ackroyd wrote: > On 6 September 2016 at 22:39, Davey Shafik wrote: > > > > > > The key to this is that it's part of the spec. If you actually want to > > follow the spec, you have to implement it this way. If you don't, then > > you're a bad person. :P > > > P

Re: [PHP-DEV] Re: [PREVOTE] PHP Engine Constants

2016-09-06 Thread Dan Ackroyd
On 6 September 2016 at 22:39, Davey Shafik wrote: > > > The key to this is that it's part of the spec. If you actually want to > follow the spec, you have to implement it this way. If you don't, then > you're a bad person. :P Perhaps you can make the RFC text be clearer then. e.g. to this bit:

Re: [PHP-DEV] Re: [PREVOTE] PHP Engine Constants

2016-09-06 Thread Davey Shafik
On Tue, Sep 6, 2016 at 1:32 PM, Dan Ackroyd wrote: > On 5 September 2016 at 19:43, Davey Shafik wrote: > > > > Instead, it would be better to check PHP_ENGINE === > > 'hhvm' && PHP_ENGINE_VERSION_ID <= 30813 > > And then when the next people who want to build an alternative engine > come along,

Re: [PHP-DEV] Re: [PREVOTE] PHP Engine Constants

2016-09-06 Thread Dan Ackroyd
On 5 September 2016 at 19:43, Davey Shafik wrote: > > Instead, it would be better to check PHP_ENGINE === > 'hhvm' && PHP_ENGINE_VERSION_ID <= 30813 And then when the next people who want to build an alternative engine come along, they will include this constant, to make their engine as 'compatib

Re: [PHP-DEV] Re: [PREVOTE] PHP Engine Constants

2016-09-05 Thread Davey Shafik
On Mon, Sep 5, 2016 at 11:19 AM, Andrea Faulds wrote: > Hi Davey, > > Davey Shafik wrote: > >> A while back I brought a small RFC to internals, that proposed a set of >> constants that were specifically for alternative implementations to >> identify themselves as such if they want to conform to t

[PHP-DEV] Re: [PREVOTE] PHP Engine Constants

2016-09-05 Thread Andrea Faulds
Hi Davey, Davey Shafik wrote: A while back I brought a small RFC to internals, that proposed a set of constants that were specifically for alternative implementations to identify themselves as such if they want to conform to the spec. https://wiki.php.net/rfc/php_engine_constant There were som