[PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] CI for 5.4

2011-11-05 Thread Ferenc Kovacs
On Sat, Nov 5, 2011 at 4:23 PM, Hannes Magnusson wrote: > On Sat, Nov 5, 2011 at 10:42, Ferenc Kovacs wrote: > > > I just noticed that the mail will be sent on each configuration build > > (debian 32bit, debian 64bit, freebsd 32bit, freebsd 64bit), which is of > > course a little bit too much, I

[PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] CI for 5.4

2011-11-05 Thread Hannes Magnusson
On Sat, Nov 5, 2011 at 10:42, Ferenc Kovacs wrote: > I just noticed that the mail will be sent on each configuration build > (debian 32bit, debian 64bit, freebsd 32bit, freebsd 64bit), which is of > course a little bit too much, I'm looking into resolving this, so to only > send email on the pare

Re: [PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] CI for 5.4

2011-11-05 Thread Ferenc Kovacs
On Sat, Nov 5, 2011 at 10:42 AM, Ferenc Kovacs wrote: > > > On Fri, Nov 4, 2011 at 2:00 AM, Ferenc Kovacs wrote: > >> >> >> On Fri, Nov 4, 2011 at 12:21 AM, Ferenc Kovacs wrote: >> >>> >>> >>> On Fri, Nov 4, 2011 at 12:20 AM, Stefan Marr wrote: >>> Hi: On 04 Nov 2011, at 00:12,

Re: [PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] CI for 5.4

2011-11-05 Thread Ferenc Kovacs
On Fri, Nov 4, 2011 at 2:00 AM, Ferenc Kovacs wrote: > > > On Fri, Nov 4, 2011 at 12:21 AM, Ferenc Kovacs wrote: > >> >> >> On Fri, Nov 4, 2011 at 12:20 AM, Stefan Marr wrote: >> >>> Hi: >>> >>> On 04 Nov 2011, at 00:12, Ferenc Kovacs wrote: >>> >>> > I almost forget to mention, but the email n

Re: [PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] CI for 5.4

2011-11-03 Thread Ferenc Kovacs
On Fri, Nov 4, 2011 at 12:21 AM, Ferenc Kovacs wrote: > > > On Fri, Nov 4, 2011 at 12:20 AM, Stefan Marr wrote: > >> Hi: >> >> On 04 Nov 2011, at 00:12, Ferenc Kovacs wrote: >> >> > I almost forget to mention, but the email notification also supports >> defining different recipients for each eve

Re: [PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] CI for 5.4

2011-11-03 Thread Ferenc Kovacs
On Fri, Nov 4, 2011 at 12:20 AM, Stefan Marr wrote: > Hi: > > On 04 Nov 2011, at 00:12, Ferenc Kovacs wrote: > > > I almost forget to mention, but the email notification also supports > defining different recipients for each event, so for example the commiters > could still get the notification f

Re: [PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] CI for 5.4

2011-11-03 Thread Stefan Marr
Hi: On 04 Nov 2011, at 00:12, Ferenc Kovacs wrote: > I almost forget to mention, but the email notification also supports defining > different recipients for each event, so for example the commiters could still > get the notification for each of their commits/builds until the build is back > t

Re: [PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] CI for 5.4

2011-11-03 Thread Ferenc Kovacs
On Thu, Nov 3, 2011 at 11:58 PM, Rasmus Lerdorf wrote: > On 11/03/2011 03:47 PM, Ferenc Kovacs wrote: > > A, it will report every test failure, but we fix all of our tests so we > > are cool. (my preference) > > But even if we do that, when a test does fail, it may take a couple of > days to fix

Re: [PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] CI for 5.4

2011-11-03 Thread Rasmus Lerdorf
On 11/03/2011 03:47 PM, Ferenc Kovacs wrote: > A, it will report every test failure, but we fix all of our tests so we > are cool. (my preference) But even if we do that, when a test does fail, it may take a couple of days to fix it. It would be nice if we didn't get an internals email for every c

Re: [PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] CI for 5.4

2011-11-03 Thread Ferenc Kovacs
On Thu, Nov 3, 2011 at 11:33 PM, Rasmus Lerdorf wrote: > On 11/03/2011 02:26 PM, Ferenc Kovacs wrote: > > We could set up the email notification any time, we would just have to > > agree where to send (internals, php-qa, creating a dedicated mailing > list?) > > and when to send (as I added to th

Re: [PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] CI for 5.4

2011-11-03 Thread Rasmus Lerdorf
On 11/03/2011 02:26 PM, Ferenc Kovacs wrote: > We could set up the email notification any time, we would just have to > agree where to send (internals, php-qa, creating a dedicated mailing list?) > and when to send (as I added to the RFC, having failing tests can be a > problem from the notificatio

Re: [PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] CI for 5.4

2011-11-03 Thread Ferenc Kovacs
On Thu, Nov 3, 2011 at 10:25 PM, Klaus Silveira wrote: > Yes, it's a wonderful setup. Great work, Ferenc! :D > > This does give a nice motivation to write more tests and increase the code > coverage, doesn't it? > Yes, and first of all, to fix the currently failing tests. We also had a discussion

[PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] CI for 5.4

2011-11-03 Thread Ferenc Kovacs
On Thu, Nov 3, 2011 at 10:22 PM, Felipe Pena wrote: > 2011/11/3 Ferenc Kovacs : > > On Thu, Nov 3, 2011 at 8:41 PM, Klaus Silveira < > cont...@klaussilveira.com>wrote: > > > >> That's kind of a general setup, Stefan. Sending an email to the commiter > >> that broke the build with details of the b

Re: [PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] CI for 5.4

2011-11-03 Thread Klaus Silveira
Yes, it's a wonderful setup. Great work, Ferenc! :D This does give a nice motivation to write more tests and increase the code coverage, doesn't it? On Thu, Nov 3, 2011 at 7:22 PM, Felipe Pena wrote: > 2011/11/3 Ferenc Kovacs : > > On Thu, Nov 3, 2011 at 8:41 PM, Klaus Silveira < > cont...@klau

[PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] CI for 5.4

2011-11-03 Thread Felipe Pena
2011/11/3 Ferenc Kovacs : > On Thu, Nov 3, 2011 at 8:41 PM, Klaus Silveira > wrote: > >> That's kind of a general setup, Stefan. Sending an email to the commiter >> that broke the build with details of the build process, as well sending an >> email to a mailing list. >> >> I'll be looking into thi