[PHP-DEV] Re: [PATCH] new function stream_socket_create_pair

2004-10-13 Thread six
hi, socket type checking removed : http://si.kz/~six/stream_socket_pair.notypecheck.diff Vincent Wez Furlong wrote: I wouldn't bother checking against known types; let sockpair() handle that. It is possible that someone might want/need to use some other value which we haven't thought of, or are e

[PHP-DEV] Re: [PATCH] new function stream_socket_create_pair

2004-10-13 Thread Wez Furlong
I wouldn't bother checking against known types; let sockpair() handle that. It is possible that someone might want/need to use some other value which we haven't thought of, or are even aware of. --Wez. On Wed, 13 Oct 2004 15:58:46 +0200, Vincent NEGRIER <[EMAIL PROTECTED]> wrote: > Here is an upd

Re: [PHP-DEV] Re: [PATCH] new function stream_socket_create_pair

2004-10-13 Thread Vincent NEGRIER
"Wez Furlong" <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> Sent: Wednesday, October 13, 2004 4:05 PM Subject: Re: [PHP-DEV] Re: [PATCH] new function stream_socket_create_pair > Hi, > at least my experience is that when a parameter's value is bad, FALSE > is retu

[PHP-DEV] Re: [PATCH] new function stream_socket_create_pair

2004-10-13 Thread Vincent NEGRIER
Here is an updated version of the patch : http://si.kz/~six/stream_socket_pair.diff It now registers STREAM_AF_* and STREAM_SOCK_* long constants, checks the domain and type against known types and passes the array of created streams as return value instead of a byref param... and the diff is agai

[PHP-DEV] Re: [PATCH] new function stream_socket_create_pair

2004-10-13 Thread Vincent NEGRIER
> > the patch is here : http://si.kz/~six/stream_socket_create_pair_patch.tgz > > > To add to Wez's comments, I'd rather see it return an array of socket > streams (or FALSE on failure), rather than return true and tuck the streams > into a by-ref parameter. It would look simpler, but on the other

[PHP-DEV] Re: [PATCH] new function stream_socket_create_pair

2004-10-12 Thread Sara Golemon
> the patch is here : http://si.kz/~six/stream_socket_create_pair_patch.tgz > To add to Wez's comments, I'd rather see it return an array of socket streams (or FALSE on failure), rather than return true and tuck the streams into a by-ref parameter. -Sara -- PHP Internals - PHP Runtime Develop