Re: [PHP-DEV] Re: [PATCH] internal class' static properties and constants

Hi Marcus Boerger, you wrote: > Hello Michael, > > Wednesday, August 17, 2005, 9:14:50 AM, you wrote: >>>+ } else if (*property == value) { >>>+ retval = SUCCESS; >>>Here you compare the address of a zval, was that intended? >>>In case you meant it, then i think it cannot be c

Re: [PHP-DEV] Re: [PATCH] internal class' static properties and constants

Hello Michael, Wednesday, August 17, 2005, 9:14:50 AM, you wrote: > Hi Marcus Boerger, you wrote: >> Hello Michael, >> >> a few questions/comments so that i can understand better: >> >> 1) Zend/zend_API.c: >> +ZEND_API int zend_declare_class_constant_stringl(zend_class_entry >> *ce, char *name,

Re: [PHP-DEV] Re: [PATCH] internal class' static properties and constants

I wrote: > Hi Marcus Boerger, you wrote: >> Before your patch we have the situation that consts can only be >> decalred in user space. Thus it is ensured that their data is >> emalloc'd and only ever needs to be const-updated once. Now that >> you have this as well as your default static propertie

Re: [PHP-DEV] Re: [PATCH] internal class' static properties and constants

Hi Marcus Boerger, you wrote: > Hello Michael, > > a few questions/comments so that i can understand better: > > 1) Zend/zend_API.c: > +ZEND_API int zend_declare_class_constant_stringl(zend_class_entry *ce, char > *name, size_t name_length, char *value, size_t value_length TSRMLS_DC) > +{ > +

Re: [PHP-DEV] Re: [PATCH] internal class' static properties and constants

Hello Michael, a few questions/comments so that i can understand better: 1) Zend/zend_API.c: +ZEND_API int zend_declare_class_constant_stringl(zend_class_entry *ce, char *name, size_t name_length, char *value, size_t value_length TSRMLS_DC) +{ + zval *constant = new_zval(ce->type & ZEND_I

Re: [PHP-DEV] Re: [PATCH] internal class' static properties and constants

Hi Michael, Thanks for sending this. Has anyone else reviewed it already? I'm assuming that this supports arrays too (unlike today as emalloc needs to be available for arrays) and has to be created/freed during RINIT/RSHUTDOWN... Andi At 03:54 PM 8/12/2005 +0200, Michael Wallner wrote: The

[PHP-DEV] Re: [PATCH] internal class' static properties and constants

I wrote: Though there's already a diff against HEAD, but it's now about 7 hours old, so it may be inapplicable. http://dev.iworks.at/PATCHES/ Actually it seems that there were no more commits, so the available patch should work fine. Regards, Mike -- PHP Internals - PHP Runtime Development

[PHP-DEV] Re: [PATCH] internal class' static properties and constants

Marcus Boerger wrote: Hello Michael, can you do this again please for HEAD (no 5.1) now that the major unicode work is done? Uhm, not until Tuesday, sorry. Though there's already a diff against HEAD, but it's now about 7 hours old, so it may be inapplicable. http://dev.iworks.at/PATCHES/ Th

Re: [PHP-DEV] Re: [PATCH] internal class' static properties and constants

Hello Michael, can you do this again please for HEAD (no 5.1) now that the major unicode work is done? marcus Friday, August 12, 2005, 3:54:58 PM, you wrote: > The patches are online at: > http://dev.iworks.at/PATCHES/ > Thanks, > -- > Michael - < mike(@)php.net > Best regards, Marcus -

[PHP-DEV] Re: [PATCH] internal class' static properties and constants

The patches are online at: http://dev.iworks.at/PATCHES/ Thanks, -- Michael - < mike(@)php.net > signature.asc Description: OpenPGP digital signature