Re: [PHP-DEV] Proposal to incrementally improve timeout and signal handling

2022-10-24 Thread Levi Morrison via internals
This kind of thing requires careful thought. My first glance through it looks good and I definitely want PHP to stop abusing the SIGPROF signal because it prevents usage by actual profilers, which is annoying. Full disclosure: I write a profiler for my job. In addition, I think that there should p

Re: [PHP-DEV] Proposal to incrementally improve timeout and signal handling

2022-10-23 Thread Tim Starling
On 21/10/22 01:11, Kévin Dunglas wrote: Here is the plan: 1. Switch to timer_create() for timeouts, but only on Linux (it's not supported on other platforms yet), when ZTS is enabled and Zend Signals is disabled. As the feature is currently entirely broken when ZTS is on, this can be considered

[PHP-DEV] Proposal to incrementally improve timeout and signal handling

2022-10-20 Thread Kévin Dunglas
Hello Internals, PHP suffers from several issues related to timeout and signal handling, especially when built with ZTS enabled. 1. The current implementation of timeouts on UNIX builds seems "fundamentally incompatible with ZTS" ( https://bugs.php.net/bug.php?id=79464#1589205685) and more anecdo