Re: [PHP-DEV] Private member/method access inconsistency

2009-01-11 Thread Robin Fernandes
>> Addressing those two points would make things even more consistent. >> I'm adding some testcases to illustrate. > > I fixed the callback case in 5_2. Need to talk to Dmitry about 5_3 and HEAD > because zend_is_callable_check_func() is damn complex now. > > -Andrei > Thanks! I noticed another i

Re: [PHP-DEV] Private member/method access inconsistency

2009-01-08 Thread Andrei Zmievski
Robin Fernandes wrote: Cool, looks like this has gone in already. A couple of comments: 1. I think the change has not been made for callbacks (so callbacks now behave differently from normal method invocations). 2. Perhaps on 5_3 and HEAD, the equivalent change should be made for __callStatic()?

Re: [PHP-DEV] Private member/method access inconsistency

2009-01-08 Thread Robin Fernandes
2009/1/6 David Coallier : >> call to __call() on private method invocation. The former approach presents >> more of a BC >> problem IMHO, so I am advocating the latter. I've attached a simple patch >> for consideration. >> > > I'd say go ahead, this sounds like common sense to be consistent in > bo

Re: [PHP-DEV] Private member/method access inconsistency

2009-01-06 Thread David Coallier
> To me it looks like a large inconsistency in the way we invoke overloaded > handlers for > members vs. methods. I am not sure how it came to be this way, but it's > probably something > we should fix. We can either remove the call to __get() on private member > access, or add > call to __call() o

[PHP-DEV] Private member/method access inconsistency

2009-01-06 Thread Andrei Zmievski
A colleague at Digg pointed me to this blog entry: http://atomized.org/2008/11/more-tough-love-from-php/ To me it looks like a large inconsistency in the way we invoke overloaded handlers for members vs. methods. I am not sure how it came to be this way, but it's probably something we shoul