Re: [PHP-DEV] Patches for Review

2012-03-04 Thread Gustavo Lopes
On Sun, 04 Mar 2012 15:02:23 +0100, Anthony Ferrara wrote: In sum, I think the rule that if a mathematical operation involves a float, the result should be a float ought to be kept. Yes, it is a must. Well, I'm not so sure about that. If you look at the docs of pow(), it describes the r

Re: [PHP-DEV] Patches for Review

2012-03-04 Thread Anthony Ferrara
>> In sum, I think the rule that if a mathematical operation involves a float, >> the result should be a float ought to be kept. > > Yes, it is a must. Well, I'm not so sure about that. If you look at the docs of pow(), it describes the return type as "base raised to the power of exp. If the resu

Re: [PHP-DEV] Patches for Review

2012-03-04 Thread Nikita Popov
On Sun, Mar 4, 2012 at 2:29 PM, Anthony Ferrara wrote: > Hey all, > [snip] > https://bugs.php.net/bug.php?id=60596 > A little code-cleanup to remove a superfluous if statement in a switch > in the spl_offset_convert_to_long function... Applied in http://svn.php.net/viewvc/?view=revision&revision=3

Re: [PHP-DEV] Patches for Review

2012-03-04 Thread Pierre Joye
On Sun, Mar 4, 2012 at 2:52 PM, Gustavo Lopes wrote: > In sum, I think the rule that if a mathematical operation involves a float, > the result should be a float ought to be kept. Yes, it is a must. -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PH

Re: [PHP-DEV] Patches for Review

2012-03-04 Thread Gustavo Lopes
On Sun, 04 Mar 2012 14:29:49 +0100, Anthony Ferrara wrote: I had messaged about these patches before, but with the 5.4 release process happening I think it slipped through the cracks. I have 3 patches that are ready for inclusion... [...] https://bugs.php.net/bug.php?id=60789 Bringing pow

[PHP-DEV] Patches for Review

2012-03-04 Thread Anthony Ferrara
Hey all, I had messaged about these patches before, but with the 5.4 release process happening I think it slipped through the cracks. I have 3 patches that are ready for inclusion... https://bugs.php.net/bug.php?id=60813 Adding a new hash_pbkdf2() function to allow for a C level implementation o