Re: [PHP-DEV] Patch for opcode caches

2008-03-20 Thread Dmitry Stogov
PROTECTED] Sent: Friday, March 14, 2008 8:24 PM To: Stas Malyshev Cc: Dmitry Stogov; Andi Gutmans; phpxcache; internals@lists.php.net Subject: Re: [PHP-DEV] Patch for opcode caches Hello Stanislav, Friday, March 14, 2008, 5:51:49 PM, you wrote: But that means we are compiling inheritance when

Re: [PHP-DEV] Patch for opcode caches

2008-03-20 Thread Marcus Boerger
2008 8:24 PM >> To: Stas Malyshev >> Cc: Dmitry Stogov; Andi Gutmans; phpxcache; internals@lists.php.net >> Subject: Re: [PHP-DEV] Patch for opcode caches >> >> >> Hello Stanislav, >> >> Friday, March 14, 2008, 5:51:49 PM, you wrote: >>

Re: [PHP-DEV] Patch for opcode caches

2008-03-18 Thread Dmitry Stogov
The patch has been just committed. You should use something like the following code to make it work. function cache_compile_file($filename) { if (!is_cached($filename)) { ... orig_compiler_options = CG(compiler_optins); CG(compiler_

Re: [PHP-DEV] Patch for opcode caches

2008-03-17 Thread phpxcache
session (or caused by TSRM/ZendEngine) seems broken in my local cvs checkout i'm not sure if it's relatived to this patch but i did 'cvs up' and some commit broke the patch (with conflicts) please commit, or roll out another diff against the PHP_5_3 cvs so i can test it again thanks -- PHP Inter

RE: [PHP-DEV] Patch for opcode caches

2008-03-17 Thread Dmitry Stogov
> -Original Message- > From: Marcus Boerger [mailto:[EMAIL PROTECTED] > Sent: Friday, March 14, 2008 9:28 PM > To: Stas Malyshev > Cc: internals@lists.php.net > Subject: Re: [PHP-DEV] Patch for opcode caches > > > Hello Stanislav, > > Friday, Marc

Re: [PHP-DEV] Patch for opcode caches

2008-03-17 Thread Ilia Alshanetsky
Keeping it seems fairly meaningless (it was a temporary hack anyway). Since 5.1 (or possibly even late 5.0) releases much of the new functionality ignores it anyway. On 14-Mar-08, at 11:23 AM, Derick Rethans wrote: On Fri, 14 Mar 2008, Dmitry Stogov wrote: however in PHP_5_3 we even keep

RE: [PHP-DEV] Patch for opcode caches

2008-03-17 Thread Dmitry Stogov
> -Original Message- > From: Marcus Boerger [mailto:[EMAIL PROTECTED] > Sent: Friday, March 14, 2008 8:24 PM > To: Stas Malyshev > Cc: Dmitry Stogov; Andi Gutmans; phpxcache; internals@lists.php.net > Subject: Re: [PHP-DEV] Patch for opcode caches > > > H

RE: [PHP-DEV] Patch for opcode caches

2008-03-17 Thread Dmitry Stogov
> -Original Message- > From: Stanislav Malyshev [mailto:[EMAIL PROTECTED] > Sent: Friday, March 14, 2008 10:11 PM > To: Rasmus Lerdorf > Cc: Marcus Boerger; Dmitry Stogov; Andi Gutmans; > internals@lists.php.net > Subject: Re: [PHP-DEV] Patch for opcode cac

RE: [PHP-DEV] Patch for opcode caches

2008-03-17 Thread Dmitry Stogov
> -Original Message- > From: Xuefer [mailto:[EMAIL PROTECTED] > Sent: Saturday, March 15, 2008 11:21 AM > To: Rasmus Lerdorf > Cc: Marcus Boerger; Stas Malyshev; Dmitry Stogov; Andi > Gutmans; internals@lists.php.net > Subject: Re: [PHP-DEV] Patch for opcode cach

Re: [PHP-DEV] Patch for opcode caches

2008-03-15 Thread Xuefer
> I don't actually see early binding as being much of a problem, the real > problem is when the same class is both early and late bound. If you > consistently always bind early or always bind late, opcode caches should > be quite happy to let you do that. But if you mix the two, things get >

Re: [PHP-DEV] Patch for opcode caches

2008-03-14 Thread Stanislav Malyshev
I don't actually see early binding as being much of a problem, the real problem is when the same class is both early and late bound. If you consistently always bind early or always bind late, opcode caches should be quite happy to let you do that. But if you mix the two, things get That's w

Re: [PHP-DEV] Patch for opcode caches

2008-03-14 Thread Marcus Boerger
Hello Stanislav, Friday, March 14, 2008, 6:48:52 PM, you wrote: > Hi! >> Lemme just think, doing inheritance at compile time before we send the stuff >> to an opcode cache can be slower then? How is that possible? After all late >> binding means we do it at run time. And no matter how much faste

Re: [PHP-DEV] Patch for opcode caches

2008-03-14 Thread Rasmus Lerdorf
Marcus Boerger wrote: Hello Stanislav, Friday, March 14, 2008, 5:51:49 PM, you wrote: But that means we are compiling inheritance when a file is loaded form the cache. The goal should be to compiling inheritance when writing to the opcode cache file. All we achieve here is a slow down. If ther

Re: [PHP-DEV] Patch for opcode caches

2008-03-14 Thread Marcus Boerger
Hello Pierre, yep, stupid me. I got confused by your wording :-) marcus Friday, March 14, 2008, 4:42:32 PM, you wrote: > On Fri, Mar 14, 2008 at 4:22 PM, Marcus Boerger <[EMAIL PROTECTED]> wrote: >> Hello Pierre, >> >> it is unused code that does not work as intended and causes trouble. And

Re: [PHP-DEV] Patch for opcode caches

2008-03-14 Thread Marcus Boerger
Hello Stanislav, Friday, March 14, 2008, 5:51:49 PM, you wrote: >> But that means we are compiling inheritance when a file is loaded form >> the cache. The goal should be to compiling inheritance when writing to >> the opcode cache file. All we achieve here is a slow down. If there is > You can

Re: [PHP-DEV] Patch for opcode caches

2008-03-14 Thread Stanislav Malyshev
But that means we are compiling inheritance when a file is loaded form the cache. The goal should be to compiling inheritance when writing to the opcode cache file. All we achieve here is a slow down. If there is You can not do that. You do not know that until runtime. something that makes thi

Re: [PHP-DEV] Patch for opcode caches

2008-03-14 Thread Marcus Boerger
Hello Dmitry, Friday, March 14, 2008, 5:08:18 PM, you wrote: >> I do not want to remove early binding. In fact I always >> wanted to have early binding as much as possible. Because >> that is faster and makes compiler caches easier. So why slow >> down stuff? A Compiler cache wants everythign

RE: [PHP-DEV] Patch for opcode caches

2008-03-14 Thread Dmitry Stogov
> I do not want to remove early binding. In fact I always > wanted to have early binding as much as possible. Because > that is faster and makes compiler caches easier. So why slow > down stuff? A Compiler cache wants everythign as static as > possible which means a compiler cache wants early b

Re: [PHP-DEV] Patch for opcode caches

2008-03-14 Thread Pierre Joye
On Fri, Mar 14, 2008 at 4:22 PM, Marcus Boerger <[EMAIL PROTECTED]> wrote: > Hello Pierre, > > it is unused code that does not work as intended and causes trouble. And > at leats it makes maintanance harder. So that is a very big reason to drop > it. Yes, I fully agree (you may have missed the

Re: [PHP-DEV] Patch for opcode caches

2008-03-14 Thread Marcus Boerger
hpxcache; internals@lists.php.net >> Subject: Re: [PHP-DEV] Patch for opcode caches >> >> >> Hello Dmitry, >> >> Monday, March 10, 2008, 1:48:05 PM, you wrote: >> >> > Hi Marcus, >> >> >> > -Original Message- >> >

RE: [PHP-DEV] Patch for opcode caches

2008-03-14 Thread Derick Rethans
On Fri, 14 Mar 2008, Dmitry Stogov wrote: > however in > PHP_5_3 we even keep ze1_compatibility_mode. > I'm not able to remove it. WHy not? It's quite broken anyway. Derick -- Derick Rethans http://derickrethans.nl | http://ezcomponents.org | http://xdebug.org -- PHP Internals - PHP Runtime

Re: [PHP-DEV] Patch for opcode caches

2008-03-14 Thread Marcus Boerger
Hello Pierre, it is unused code that does not work as intended and causes trouble. And at leats it makes maintanance harder. So that is a very big reason to drop it. marcus Friday, March 14, 2008, 11:11:06 AM, you wrote: > On Fri, Mar 14, 2008 at 11:06 AM, Hannes Magnusson > <[EMAIL PROTECTED

Re: [PHP-DEV] Patch for opcode caches

2008-03-14 Thread Pierre Joye
On Fri, Mar 14, 2008 at 11:06 AM, Hannes Magnusson <[EMAIL PROTECTED]> wrote: > On Fri, Mar 14, 2008 at 9:46 AM, Dmitry Stogov <[EMAIL PROTECTED]> wrote: > > > > Removing early-binding at all might be a subject for PHP6, however in > > PHP_5_3 we even keep ze1_compatibility_mode. > > http://n

Re: [PHP-DEV] Patch for opcode caches

2008-03-14 Thread Hannes Magnusson
On Fri, Mar 14, 2008 at 9:46 AM, Dmitry Stogov <[EMAIL PROTECTED]> wrote: > > Removing early-binding at all might be a subject for PHP6, however in > PHP_5_3 we even keep ze1_compatibility_mode. http://news.php.net/php.internals/36085 -Hannes -- PHP Internals - PHP Runtime Development Mailing

RE: [PHP-DEV] Patch for opcode caches

2008-03-14 Thread Dmitry Stogov
Hi Marcus, > -Original Message- > From: Marcus Boerger [mailto:[EMAIL PROTECTED] > Sent: Thursday, March 13, 2008 9:27 PM > To: Dmitry Stogov > Cc: Andi Gutmans; Stas Malyshev; phpxcache; internals@lists.php.net > Subject: Re: [PHP-DEV] Patch for opcode caches &g

Re: [PHP-DEV] Patch for opcode caches

2008-03-13 Thread Marcus Boerger
hans; internals Mailing List; Andi Gutmans; Stas >> > Malyshev; phpxcache >> > Subject: Re: [PHP-DEV] Patch for opcode caches >> > >> > Hello Dmitry, >> > >> > please don't apply. The patch looks rather rough and untested (see >> > b

RE: [PHP-DEV] Patch for opcode caches

2008-03-11 Thread Dmitry Stogov
omments about compiler options) Thanks. Dmitry. > -Original Message- > From: Dmitry Stogov > Sent: Monday, March 10, 2008 3:48 PM > To: 'Marcus Boerger' > Cc: Andi Gutmans; Stas Malyshev; 'phpxcache'; > 'internals@lists.php.net' > Subject

Re: [PHP-DEV] Patch for opcode caches

2008-03-10 Thread Stanislav Malyshev
Hi! This does not work. Does not work either. And this does also not work. The reason is that you did not update the table that allows those Which table are you referring to? -- Stanislav Malyshev, Zend Software Architect [EMAIL PROTECTED] http://www.zend.com/ (408)253-8829 MSN: [EMAIL PR

RE: [PHP-DEV] Patch for opcode caches

2008-03-10 Thread Dmitry Stogov
Hi Marcus, > > -Original Message- > > From: Marcus Boerger [mailto:[EMAIL PROTECTED] > > Sent: Sunday, March 09, 2008 3:00 PM > > To: Dmitry Stogov > > Cc: Derick Rethans; internals Mailing List; Andi Gutmans; Stas > > Malyshev; phpxcache > &g

Re: [PHP-DEV] Patch for opcode caches

2008-03-10 Thread Robin Fernandes
Hi phpxcache, On 08/03/2008, phpxcache <[EMAIL PROTECTED]> wrote: > all test cases that pass without XCache now pass > with XCache too. Are these tests that are already in the cvs repository? If not, it would be great to get them in. Sounds like they could be useful whether or not the patch gets

Re: [PHP-DEV] Patch for opcode caches

2008-03-09 Thread phpxcache
On Mon, Mar 10, 2008 at 5:59 AM, Marcus Boerger <[EMAIL PROTECTED]> wrote: > Hello Dmitry, > > please don't apply. The patch looks rather rough and untested (see below). > Also I really disagree to making the engine even more complex and adding > even more different behavior ways. That way we ju

Re: [PHP-DEV] Patch for opcode caches

2008-03-09 Thread Marcus Boerger
Hello Dmitry, please don't apply. The patch looks rather rough and untested (see below). Also I really disagree to making the engine even more complex and adding even more different behavior ways. That way we just introduce more errors as we cannot test the engine in all its modes. We simply do no

Re: [PHP-DEV] Patch for opcode caches

2008-03-08 Thread phpxcache
checked and it works, all test cases that pass without XCache now pass with XCache too. i'll commit after your commit in ZendEngine thanks -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Patch for opcode caches

2008-03-07 Thread Derick Rethans
On Fri, 7 Mar 2008, Dmitry Stogov wrote: > The attached patch for PHP_5_3 is going to provide general solution to > control some aspects of PHP compilation. It is absolutely necessary for > all opcode caches to make cached scripts work exactly in the same way as > non-cached. There's no attached

[PHP-DEV] Patch for opcode caches

2008-03-07 Thread Dmitry Stogov
Hi, The attached patch for PHP_5_3 is going to provide general solution to control some aspects of PHP compilation. It is absolutely necessary for all opcode caches to make cached scripts work exactly in the same way as non-cached. The problem occurs because early binding of inherited classes is n