Re: [PHP-DEV] Patch for ext/openssl to support CN_match with asterisk

2010-02-22 Thread Bostjan Skufca
Below is the valgrind output. Seem like it is OpenSSL's fault? Thus I am not filling another bug report. Or can you do anything about it? b. ==12933== ==12933== IN SUMMARY: 563339 errors from 307 contexts (suppressed: 69 from 1) ==12933== ==12933== malloc/free: in use at exit: 1,628 bytes in 44

Re: [PHP-DEV] Patch for ext/openssl to support CN_match with asterisk

2010-02-21 Thread Pierre Joye
hi, can you run it through valgrind and paste the output in a new bug report please? Cheers, On Sun, Feb 21, 2010 at 2:47 AM, Bostjan Skufca wrote: > a) If you would like to see an example of memory leak, here is how I > reproduce it. > > 1. Clone this git repository: > http://github.com/bostja

Re: [PHP-DEV] Patch for ext/openssl to support CN_match with asterisk

2010-02-20 Thread Bostjan Skufca
a) If you would like to see an example of memory leak, here is how I reproduce it. 1. Clone this git repository: http://github.com/bostjan/PHP-application-server 2. Copy/move/Symlink contents to /opt/daemons/AppSrv 3. cd to /opt/daemons/AppSrv/demos/demo_https 4. start the daemon: ./demo -d5 -

Re: [PHP-DEV] Patch for ext/openssl to support CN_match with asterisk

2010-02-20 Thread Bostjan Skufca
The patch includes code which is very similar but it's functionality goes just the other way around. The original code takes remote CN and if that contains asterisk, it tries to 'limited-wildcard-match' of CN_match against remote CN (remote CN is the pattern in this case, if you will). On the oth

Re: [PHP-DEV] Patch for ext/openssl to support CN_match with asterisk

2010-02-20 Thread Pierre Joye
hi, Is it not suppose to work already? As your patch basically does what is done earlier in the code if match fails. If there is a bug in this area, we should fix instead of adding the same thing later :) I will check this issue next week. Btw, there is no chance to get this in 5.2.13 or 5.3.2 a

[PHP-DEV] Patch for ext/openssl to support CN_match with asterisk

2010-02-20 Thread Bostjan Skufca
Hi! I've created a patch that enables PHP to do "limited wildcard matching" if CN_match option in stream context is specified as '*.example.org'. Also I have filled a bug report for this, here: http://bugs.php.net/bug.php?id=51100 Patch is here: http://source.a2o.si/php/php-ext-openssl-CN_match-w