Re: [PHP-DEV] Patch for adding elements to ArrayAccess

2004-01-03 Thread Andi Gutmans
I don't think the ArrayAccess interface should work with the $a[] notation. I think E_ERROR is appropriate. Andi At 07:04 PM 1/3/2004 +0600, Simeon Koptelov wrote: Hello internals, Could anyone who can commit to CVS review this patch and commit it if it's OK? The patch was made for php5-200401021

Re: [PHP-DEV] Patch for adding elements to ArrayAccess

2004-01-03 Thread Marcus Boerger
Hello Simeon, Saturday, January 3, 2004, 2:04:45 PM, you wrote: > Hello internals, > Could anyone who can commit to CVS review this patch and commit it if it's OK? > The patch was made for php5-200401021030 snapshot, the file > zend_object_handlers.c. It fixes the bug that using $a[] = 'Somethi

Re: [PHP-DEV] Patch for adding elements to ArrayAccess

2004-01-03 Thread Derick Rethans
On Sat, 3 Jan 2004, Simeon Koptelov wrote: > Could anyone who can commit to CVS review this patch and commit it if it's OK? > The patch was made for php5-200401021030 snapshot, the file > zend_object_handlers.c. It fixes the bug that using $a[] = 'Something' where > $a is instance of ArrayAccess w

[PHP-DEV] Patch for adding elements to ArrayAccess

2004-01-03 Thread Simeon Koptelov
Hello internals, Could anyone who can commit to CVS review this patch and commit it if it's OK? The patch was made for php5-200401021030 snapshot, the file zend_object_handlers.c. It fixes the bug that using $a[] = 'Something' where $a is instance of ArrayAccess will invoke offsetSet() with empt