RE: [PHP-DEV] Patch for bug #65312: Segmentation fault with filesize=4096

2017-05-15 Thread Anatol Belski
Hi, > -Original Message- > From: Richard H Lee [mailto:ricardohenry...@gmail.com] > Sent: Thursday, May 11, 2017 3:18 PM > To: internals@lists.php.net > Subject: [PHP-DEV] Patch for bug #65312: Segmentation fault with filesize=4096 > > I submitted a patch for bug

[PHP-DEV] Patch for bug #65312: Segmentation fault with filesize=4096

2017-05-11 Thread Richard H Lee
I submitted a patch for bug #65312 "Segmentation fault with filesize=4096". It's to do with the way Cygwin handles mmap()ing. It is not a duplicate of another bug as marked, it is specific to Cygwin. I'm not sure about the release structure of PHP, but it would be great if I could get this pat

[PHP-DEV] Patch for bug #60075

2012-03-05 Thread Stuart Dallas
Hi all, I've made a patch for #60075 because it's a feature I'll find very useful. It's my first patch so it'd be great to get some feedback. https://bugs.php.net/bug.php?id=60075 Thanks. -Stuart -- Stuart Dallas 3ft9 Ltd http://3ft9.com/

Re: [PHP-DEV] Patch for Bug #48877 "bindValue" and "bindParam" do not work for PDO Firebird

2011-12-10 Thread marius adrian popa
On Sat, Dec 10, 2011 at 2:23 PM, wrote: > Hi, > > Here is my patch for the bug 48877 (https://bugs.php.net/bug.php?id=48877) I will check and apply it -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Patch for Bug #48877 "bindValue" and "bindParam" do not work for PDO Firebird

2011-12-10 Thread DAbramov
Hi, Here is my patch for the bug 48877 (https://bugs.php.net/bug.php?id=48877) Index: ext/pdo_firebird/firebird_driver.c === --- ext/pdo_firebird/firebird_driver.c (revision 320803) +++ ext/pdo_firebird/firebird_driver.c (working c

Re: [PHP-DEV] Patch for Bug #60164 / Phar __HALT_COMPILER() scanning issue

2011-11-10 Thread Ralph Schindler
All of the existing tests run. I will make one change as per C. Jones request to use a const for the hard coded 1024 window (since it's used twice). Also, I am unable to run the php-tests.php with the -m (valgrind) on my mac, so I'll need to run those on linux before I commit. In the mean t

Re: [PHP-DEV] Patch for Bug #60164 / Phar __HALT_COMPILER() scanning issue

2011-11-10 Thread Rasmus Lerdorf
On 11/10/2011 11:44 AM, Ralph Schindler wrote: > Hey all, > > I've spent a bunch of time tracking down this issue (which was > intermittent at best) and have identified the problem and have a patch > for the solution. > > Details here: https://bugs.php.net/bug.php?id=60164 > > The attached patch

[PHP-DEV] Patch for Bug #60164 / Phar __HALT_COMPILER() scanning issue

2011-11-10 Thread Ralph Schindler
Hey all, I've spent a bunch of time tracking down this issue (which was intermittent at best) and have identified the problem and have a patch for the solution. Details here: https://bugs.php.net/bug.php?id=60164 The attached patch is against trunk, PHP_5_4, & PHP_5_3. Seeing as though I've

Re: [PHP-DEV] Patch for Bug #51344: FILTER_NULL_ON_FAILURE flag automatically set in filter_input() functions.

2010-04-19 Thread Adam Harvey
Hi Mats, On 20 April 2010 00:18, Mats Lindh wrote: > The filter_input function has an errornous check for the > FILTER_NULL_ON_FAILURE flag, where it returns NULL if it is NOT set, > and not if it is set. > > I added the patch to the bug tracker over a week ago, but it seems > like it has gone un

[PHP-DEV] Patch for Bug #51344: FILTER_NULL_ON_FAILURE flag automatically set in filter_input() functions.

2010-04-19 Thread Mats Lindh
Hi, The filter_input function has an errornous check for the FILTER_NULL_ON_FAILURE flag, where it returns NULL if it is NOT set, and not if it is set. I added the patch to the bug tracker over a week ago, but it seems like it has gone unnoticed: http://bugs.php.net/bug.php?id=51344 Would be gr

Re: [PHP-DEV] PATCH for bug #47199

2010-02-10 Thread Sokolov Evgeniy
Oups. Haven't noticed the attachment. I will try to attach the file again. 2010/2/10 Sokolov Evgeniy : > No problem. I will remember for the future > > 2010/2/10 Pierre Joye : >> Can you attach the patch instead of copying it in your post? Simply >> name it mypatch.txt (.txt is important for the l

Re: [PHP-DEV] PATCH for bug #47199

2010-02-10 Thread Sokolov Evgeniy
No problem. I will remember for the future 2010/2/10 Pierre Joye : > Can you attach the patch instead of copying it in your post? Simply > name it mypatch.txt (.txt is important for the list). > > 2010/2/10 Sokolov Evgeniy : >> Thank you very much. This patch is passed, also as other patches from

Re: [PHP-DEV] PATCH for bug #47199

2010-02-10 Thread Pierre Joye
Can you attach the patch instead of copying it in your post? Simply name it mypatch.txt (.txt is important for the list). 2010/2/10 Sokolov Evgeniy : > Thank you very much. This patch is passed, also as other patches from > this extension. It's time for choose next bug :) > > > > Index: ext/pgsql/

Re: [PHP-DEV] PATCH for bug #47199

2010-02-10 Thread Sokolov Evgeniy
Thank you very much. This patch is passed, also as other patches from this extension. It's time for choose next bug :) Index: ext/pgsql/tests/bug47199.phpt === --- ext/pgsql/tests/bug47199.phpt (revision 0) +++ ext/pgsql/tests

Re: [PHP-DEV] PATCH for bug #47199

2010-02-09 Thread Daniel Convissor
Hi Skolov: > I just run "php tests/27_bug47199.phpt" and check the result output. > Is this correct way? Use an EXPECT or EXPECTF section. See http://qa.php.net/phpt_details.php for more information. Thanks, --Dan -- T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y

Re: [PHP-DEV] PATCH for bug #47199

2010-02-09 Thread Joey Smith
If anyone ever needs me to host a patch, there's more than enough room at patch.joeysmith.com, just email me the patch as an attachment off-list. It'd probably be better than relying on a pastebin. On Tue, Feb 09, 2010 at 04:38:44PM +0100, Johannes Schlüter wrote: > Hi, > > On Tue, 2010-02-09 at

Re: [PHP-DEV] PATCH for bug #47199

2010-02-09 Thread Johannes Schlüter
Hi, On Tue, 2010-02-09 at 20:11 +0500, Sokolov Evgeniy wrote: > > did you really run this test and was it successful? - doesn't looklike > > for me. > I just run "php tests/27_bug47199.phpt" and check the result output. > Is this correct way? The easy way to run it using the test Framework is by

Re: [PHP-DEV] PATCH for bug #47199

2010-02-09 Thread Sokolov Evgeniy
> did you really run this test and was it successful? - doesn't looklike > for me. I just run "php tests/27_bug47199.phpt" and check the result output. Is this correct way? >> Property changes on: tests/27_bug47199.phpt > This isn't needed. Okey, I just use previous test in this dir as example.

Re: [PHP-DEV] PATCH for bug #47199

2010-02-09 Thread Johannes Schlüter
Евгений, thanks for the patch.I didn't fully review it but I wonder about a thing: On Tue, 2010-02-09 at 16:27 +0500, Соколов Евгений wrote: > Index: tests/27_bug47199.phpt > === > --- tests/27_bug47199.phpt(revision 0) > +++ tes

[PHP-DEV] PATCH for bug #47199

2010-02-09 Thread Соколов Евгений
Index: tests/27_bug47199.phpt === --- tests/27_bug47199.phpt (revision 0) +++ tests/27_bug47199.phpt (revision 0) @@ -0,0 +1,23 @@ +--TEST-- +Bug #47199 pg_delete fails on NULL +--SKIPIF-- + +--FILE-- + NULL, 'not_null_field

Re: [PHP-DEV] Patch for bug #49936

2009-11-15 Thread Felipe Pena
Hi Pierrick, 2009/11/13 Pierrick Charron > Hi, > > I created a patch for the bug #49936. > > The problem was due to the new way to manage references of stream context. > The patch increase the refcount of the context when it's assigned to a > stream (in the method php_stream_context_set). > A ze

[PHP-DEV] Patch for bug #49936

2009-11-13 Thread Pierrick Charron
Hi, I created a patch for the bug #49936. The problem was due to the new way to manage references of stream context. The patch increase the refcount of the context when it's assigned to a stream (in the method php_stream_context_set). A zend_list_delete is already called on the context when the s

Re: [PHP-DEV] Patch for Bug #49757

2009-10-05 Thread Ilia Alshanetsky
Thanks for the patch, a patch closely based on your was just applied to SVN. On 2009-10-03, at 12:40 PM, Florian Anderiasch wrote: Hello, I've tried to fix http://bugs.php.net/bug.php?id=49757 As it's my first patch in c, any reviews and suggestions would be very welcome. Greetings, Florian

[PHP-DEV] Patch for Bug #49757

2009-10-03 Thread Florian Anderiasch
Hello, I've tried to fix http://bugs.php.net/bug.php?id=49757 As it's my first patch in c, any reviews and suggestions would be very welcome. Greetings, Florian Index: ext/standard/basic_functions.c === --- ext/standard/basic_functi

Re: [PHP-DEV] PATCH for bug 48774

2009-07-20 Thread Jani Taskinen
On 07/18/2009 07:03 PM, Sriram Natarajan wrote: Jani Taskinen wrote: Sriram Natarajan wrote: Hi I was looking into CR: 48774(http://bugs.php.net/bug.php?id=48774&thanks=3) and was hoping if some one can kindly review this patch. This patch does address the SEGV issue reported in the bug. Can th

Re: [PHP-DEV] Patch for Bug #

2009-07-20 Thread David Zülke
On 20.07.2009, at 12:42, Jani Taskinen wrote: On 07/15/2009 08:49 PM, David Zülke wrote: Hi there, attached are patches for http://bugs.php.net/48929. Big kudos to Tjerk Anne and Arnaud, this forking HTTP server stuff for testing the stream wrapper is genius. Ehem..was this ever committe

Re: [PHP-DEV] Patch for Bug #

2009-07-20 Thread Jani Taskinen
On 07/15/2009 08:49 PM, David Zülke wrote: Hi there, attached are patches for http://bugs.php.net/48929. Big kudos to Tjerk Anne and Arnaud, this forking HTTP server stuff for testing the stream wrapper is genius. Ehem..was this ever committed? And don't you have svn access yourself anyway?

Re: [PHP-DEV] PATCH for bug 48774

2009-07-18 Thread Sriram Natarajan
Jani Taskinen wrote: Sriram Natarajan wrote: Hi I was looking into CR: 48774(http://bugs.php.net/bug.php?id=48774&thanks=3) and was hoping if some one can kindly review this patch. This patch does address the SEGV issue reported in the bug. Can this be applied to PHP 5.3 and PHP 5.2 as well

Re: [PHP-DEV] PATCH for bug 48774

2009-07-18 Thread Jani Taskinen
Sriram Natarajan wrote: Hi I was looking into CR: 48774(http://bugs.php.net/bug.php?id=48774&thanks=3) and was hoping if some one can kindly review this patch. This patch does address the SEGV issue reported in the bug. Can this be applied to PHP 5.3 and PHP 5.2 as well ? Index: ext/curl/

[PHP-DEV] PATCH for bug 48774

2009-07-17 Thread Sriram Natarajan
Hi I was looking into CR: 48774(http://bugs.php.net/bug.php?id=48774&thanks=3) and was hoping if some one can kindly review this patch. This patch does address the SEGV issue reported in the bug. Can this be applied to PHP 5.3 and PHP 5.2 as well ? Index: ext/curl/interface.c =

[PHP-DEV] Patch for Bug #

2009-07-15 Thread David Zülke
Hi there, attached are patches for http://bugs.php.net/48929. Big kudos to Tjerk Anne and Arnaud, this forking HTTP server stuff for testing the stream wrapper is genius. - David Index: ext/standard/tests/http/bug48929.phpt ===

Re: [PHP-DEV] Patch for bug #48575

2009-06-18 Thread Gwynne Raskind
On Jun 18, 2009, at 10:55 AM, Scott MacVicar wrote: Here is a nice simple patch for #48575 which rips out the mach-o/dyld.h functionality in Zend (as suggested by the original reporter and the Apple comment). According to my testing this not only doesn't break anything, but actually doesn't ch

Re: [PHP-DEV] Patch for bug #48575

2009-06-18 Thread Scott MacVicar
Gwynne Raskind wrote: > On Jun 18, 2009, at 10:46 AM, Gwynne Raskind wrote: >> Here is a nice simple patch for #48575 which rips out the >> mach-o/dyld.h functionality in Zend (as suggested by the original >> reporter and the Apple comment). According to my testing this not only >> doesn't break an

Re: [PHP-DEV] Patch for bug #48575

2009-06-18 Thread Gwynne Raskind
On Jun 18, 2009, at 10:46 AM, Gwynne Raskind wrote: Here is a nice simple patch for #48575 which rips out the mach-o/ dyld.h functionality in Zend (as suggested by the original reporter and the Apple comment). According to my testing this not only doesn't break anything, but actually doesn't

[PHP-DEV] Patch for bug #48575

2009-06-18 Thread Gwynne Raskind
Here is a nice simple patch for #48575 which rips out the mach-o/ dyld.h functionality in Zend (as suggested by the original reporter and the Apple comment). According to my testing this not only doesn't break anything, but actually doesn't change anything either except removing some dead co

Re: [PHP-DEV] patch for bug #47839

2009-04-20 Thread Kalle Sommer Nielsen
Hi Florian 2009/4/21 Florian Anderiasch : > Hello, > bug #47839 > > Here's a small patch, trying to add the manual page as well (got karma > there) once I figured out how insert a new one, but I can't access > php-src/UPGRADING obviously. > > Greetings, > Florian > > --- UPGRADING.old       2009-0

[PHP-DEV] patch for bug #47839

2009-04-20 Thread Florian Anderiasch
Hello, bug #47839 Here's a small patch, trying to add the manual page as well (got karma there) once I figured out how insert a new one, but I can't access php-src/UPGRADING obviously. Greetings, Florian --- UPGRADING.old 2009-04-18 07:22:26.0 -0400 +++ UPGRADING 2009-04-18 07:23

[PHP-DEV] Patch for bug #42322

2007-10-13 Thread Martin Jansen
Attached is a patch and a corresponding test case for bug #42322 against the PHP_5_3 branch. (Antony suggested I don't supply PDO patches against HEAD.) - Martin Index: ext/pdo_mysql/mysql_statement.c === RCS file: /repository/php

Re: [PHP-DEV] Patch for bug# 41822

2007-10-05 Thread Rob Thompson
Hi Antony, Antony Dovgal wrote: > Rob, I believe you're looking into wrong place. > You should be patching virtual_file_ex() in TSRM/tsrm_virtual_cwd.c, the root > of > all evils is there as this function is used by expand_filepath() and in all > other places. Ok, originally was going to try

[PHP-DEV] Patch for bug 42637

2007-10-05 Thread Bill Moran
I have added information on how I fixed #42637 to the ticket: http://bugs.php.net/bug.php?id=42637 It's a one-line fix. I'd be interested in others testing this in their environment and a developer reviewing it. It'd be nice to see it checked in for 5.2.5 -- Bill Moran Collaborative Fusion In

Re: [PHP-DEV] Patch for bug# 41822

2007-10-05 Thread Antony Dovgal
On 05.10.2007 11:09, Rob Thompson wrote: > Here is a patch for bug 41822. The expand_filepath() function will not > work in Solaris if a non-root user attempts to read a file under a > directory with only (--x) permissions. > > Currently expand_path() returns NULL and no FD is opened, although th

[PHP-DEV] Patch for bug# 41822

2007-10-05 Thread Rob Thompson
Here is a patch for bug 41822. The expand_filepath() function will not work in Solaris if a non-root user attempts to read a file under a directory with only (--x) permissions. Currently expand_path() returns NULL and no FD is opened, although the file is readable. This patch adds a last-ditch

[PHP-DEV] Patch for bug #25361

2007-08-02 Thread Richard Quadling
Hi. Whilst 25361 is not a PHP bug per se, the patch I've built (but can't test) should deal with it. The patch is available at http://pastie.caboo.se/84303 If you need more info, I'm more than willing to help out. Ashar Lohmar <[EMAIL PROTECTED]> put me onto this fix - he had a similar issue wi

Re: [PHP-DEV] Patch for bug #40938

2007-04-12 Thread Stanislav Malyshev
Hello, the BUG #38236(http://bugs.php.net/bug.php?id=38236),correctly addressed and fixed in the PHP 5.x codebase, is still present in the PHP 4.4.x codebase. I've tested and reproduced the same problem with many installations ranging from PHP 4.4.0 to PHP 4.4.6 included. I've applied the patch.

[PHP-DEV] Patch for bug #40938

2007-04-11 Thread Andrea
Hello, the BUG #38236(http://bugs.php.net/bug.php?id=38236),correctly addressed and fixed in the PHP 5.x codebase, is still present in the PHP 4.4.x codebase. I've tested and reproduced the same problem with many installations ranging from PHP 4.4.0 to PHP 4.4.6 included. I've used the relevant p

[PHP-DEV] [PATCH] For Bug #39538

2006-11-19 Thread David Soria Parra
Hi Internals, I tried to fix the newline bug #39538 (http://bugs.php.net/bug.php?id=39538) that appears using fgetcsv with unix newlines LF, instead of the csv rfc CRLF. I didn't fix the backslash escape stuff, as this might be expected behviour. Greets David ([EMAIL PROTECTED]) The patch again

[PHP-DEV] [PATCH] For Bug #38770

2006-11-15 Thread David Soria Parra
Hi internals, I tried to fix http://bugs.php.net/bug.php?id=38770. The pack and unpack function returns different values on different platform for options like "N". Example: print_r(unpack("N", pack("N", -3000))); prints -3000 und x86 and 4294937296 on x86_64. That happens because all the 32

[PHP-DEV] Patch for bug #35512

2005-12-01 Thread Ryan Dingman
Here's a patch for bug #35512. I'm hoping that this can be included in PHP 5.1.2 Thanks, Ryan Dingman [EMAIL PROTECTED] Next Online Mortgage Technologies, Inc. Index: ZendEngine2/zend.c === RCS file: /repository/ZendEngine2/z

Re: [PHP-DEV] Patch for bug report #35243

2005-11-18 Thread David
L PROTECTED] Cc: internals@lists.php.net Date: Fri, 18 Nov 2005 11:25:34 -0500 Subject: Re: [PHP-DEV] Patch for bug report #35243 Please send patches as plain text MIME attachments, and ideally include a URL where it can be downloaded as well. --Wez. _

Re: [PHP-DEV] Patch for bug report #35243

2005-11-18 Thread Wez Furlong
Please send patches as plain text MIME attachments, and ideally include a URL where it can be downloaded as well. --Wez. On 11/18/05, David <[EMAIL PROTECTED]> wrote: > > I've recently opened a bug report #35243, and was requested to send the patch > in unified diff format to this list. Here it

[PHP-DEV] Patch for bug report #35243

2005-11-18 Thread David
I've recently opened a bug report #35243, and was requested to send the patch in unified diff format to this list. Here it is, as requested, both in plaintext, and uuencoded (in case the mailer really messes things up). I'd appreciate any feedback, as this is my first time posting a patch.

Re: [PHP-DEV] Patch for bug #34565

2005-09-21 Thread Ilia Alshanetsky
Patch applied, thanks. Ilia -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Patch for bug #34565

2005-09-20 Thread Marco Tabini
[Resending with patch inline] Hi-- Could someone with karma check that this patch is ok for bug #34565 and commit it to CVS? The patch is against HEAD -- not sure if a separate commit needs to be made against the 4.x and 5.x branches (and would appreciate some pointers on this topic). Cheers!

[PHP-DEV] Patch for bug #34565

2005-09-20 Thread Marco Tabini
[Resending with patch in text file. I'm planning on getting this right one of these days] Hi-- Could someone with karma check that this patch is ok for bug #34565 and commit it to CVS? The patch is against HEAD -- not sure if a separate commit needs to be made against the 4.x and 5.x branches (an

[PHP-DEV] Patch for bug #34565

2005-09-20 Thread Marco Tabini
Hi-- Could someone with karma check that this patch is ok for bug #34565 and commit it to CVS? The patch is against HEAD -- not sure if a separate commit needs to be made against the 4.x and 5.x branches (and would appreciate some pointers on this topic). Cheers! Marco -- PHP Internals - PHP

RE: [PHP-DEV] Patch for bug 29334 Daylight Savings Win32

2005-01-24 Thread Carter, John
ly get it wrong again. John. -Original Message- From: Jani Taskinen [mailto:[EMAIL PROTECTED] Sent: 24 January 2005 04:44 To: Carter, John Cc: internals@lists.php.net Subject: Re: [PHP-DEV] Patch for bug 29334 Daylight Savings Win32 This "fix" is not very ideal considering

Re: [PHP-DEV] Patch for bug 29334 Daylight Savings Win32

2005-01-23 Thread Jani Taskinen
This "fix" is not very ideal considering this note about tm_isdst property: "Positive value if daylight saving time is in effect; 0 if daylight saving time is not in effect; negative value if status of daylight saving time is unknown. If the TZ environment variable is set, th

Re: [PHP-DEV] Patch for bug 29334 Daylight Savings Win32

2005-01-15 Thread Derick Rethans
On Fri, 14 Jan 2005, Carter, John wrote: > This bug's been open a while (since July). I placed a small patch in > the comments in October (repeated below); can someone review and > commit please? It looks OK, but I can't try it as I don't use Windows. Derick -- Derick Rethans http://derickreth

[PHP-DEV] Patch for bug 29334 Daylight Savings Win32

2005-01-14 Thread Carter, John
Hi, This bug's been open a while (since July). I placed a small patch in the comments in October (repeated below); can someone review and commit please? John. patch to win32 sendmail.c: --- old.c 2004-09-08 21:33:17.640625000 +0100 +++ new.c 2004-09-08 21:39:06.890625000 +0100 @@ -

[PHP-DEV] [PATCH] for bug #26737

2004-08-13 Thread Curt Zirzow
As of 5.0.1, when a user returns a property name in the array that is returned by __sleep(), var.c:php_var_serialize_class() doesn't properly find the protected or private members since the names in the table are mangled. This patch, attempts to fix this problem by checking the mangled private an

Re: [PHP-DEV] patch for bug #28999

2004-07-09 Thread Daniel Convissor
Curt: > http://bugs.php.net/28999 Thanks for the patch. I added a comment pointing to your post. --Dan -- T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y data intensive web and database programming http://www.AnalysisAndSolutions.com/ 4015 7th

[PHP-DEV] patch for bug #28999

2004-07-07 Thread Curt Zirzow
http://bugs.php.net/28999 It seems the behaviour of exec() and the array being returned changed when iliaa revamped a lot of code pre 4_3_2RC1, which caused the array being passed to always get initialized. So it does seem questionable if it should be refixed since this behaviour has been around

Re: [PHP-DEV] patch for bug #22580

2003-03-25 Thread Ilia A.
Where is the patch? ;) Ilia On March 24, 2003 09:10 pm, chihfeng wrote: > Hi, > > Attached is a patch for Bug#22580. Since I don't have > a CVS account. Could somebody help me install > the patch? > > Thanks!! > > --Jeff -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, v

[PHP-DEV] patch for bug #22580

2003-03-24 Thread chihfeng
Hi,   Attached is a patch for Bug#22580. Since I don't have a CVS account. Could somebody help me install the patch?   Thanks!!   --Jeff -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] patch for bug #22805

2003-03-21 Thread Moriyoshi Koizumi
Attached is the patch for bug #22805. The problem is because the total length of buckets obtained in each ap_get_brigade call isn't necessarily as long as expected by SAPI_POST_READER_FUNC if more data are coming in the stream. Moriyoshi Index: sapi/apache2handler/sapi_apache2.c