Re: [PHP-DEV] Parse error: Invalid body indentation level

2018-05-29 Thread Kingsquare.nl - Robin Speekenbrink
Op di 29 mei 2018 om 10:27 schreef Niklas Keller : > Am Di., 29. Mai 2018 um 07:34 Uhr schrieb Sebastian Bergmann < > sebast...@php.net>: > > > Am 28.05.2018 um 22:16 schrieb Nikita Popov: > > > Good point, I have added a note in UPGRADING in > > > > > > https://github.com/php/php-src/commit/c7046

Re: [PHP-DEV] Parse error: Invalid body indentation level

2018-05-29 Thread Niklas Keller
Am Di., 29. Mai 2018 um 07:34 Uhr schrieb Sebastian Bergmann < sebast...@php.net>: > Am 28.05.2018 um 22:16 schrieb Nikita Popov: > > Good point, I have added a note in UPGRADING in > > > https://github.com/php/php-src/commit/c70468b8d3c1d6711da0db84cba30d87d2482e5c > > Thank you so much, Nikita!

Re: [PHP-DEV] Parse error: Invalid body indentation level

2018-05-28 Thread Sebastian Bergmann
Am 28.05.2018 um 22:16 schrieb Nikita Popov: > Good point, I have added a note in UPGRADING in > https://github.com/php/php-src/commit/c70468b8d3c1d6711da0db84cba30d87d2482e5c Thank you so much, Nikita! -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php

Re: [PHP-DEV] Parse error: Invalid body indentation level

2018-05-28 Thread Christoph M. Becker
On 28.05.2018 at 18:56, Rasmus Schultz wrote: >>> Yes, this is an expected result under the flexible heredoc RFC. To avoid >>> issues, please use a heredoc label that does not occur within the string. >> >> Hmkay, so code that worked fine with PHP 7.1 and PHP 7.2 breaks with PHP >> 7.3. This break

Re: [PHP-DEV] Parse error: Invalid body indentation level

2018-05-28 Thread Nikita Popov
On Mon, May 28, 2018 at 3:32 PM, Sebastian Bergmann wrote: > Am 28.05.2018 um 14:51 schrieb Nikita Popov: > > Yes, this is an expected result under the flexible heredoc RFC. To avoid > > issues, please use a heredoc label that does not occur within the string. > > Hmkay, so code that worked fine

Re: [PHP-DEV] Parse error: Invalid body indentation level

2018-05-28 Thread Rasmus Schultz
> > Yes, this is an expected result under the flexible heredoc RFC. To avoid > > issues, please use a heredoc label that does not occur within the string. > > Hmkay, so code that worked fine with PHP 7.1 and PHP 7.2 breaks with PHP > 7.3. This breaking change should at least be prominently document

Re: [PHP-DEV] Parse error: Invalid body indentation level

2018-05-28 Thread Sebastian Bergmann
Am 28.05.2018 um 14:51 schrieb Nikita Popov: > Yes, this is an expected result under the flexible heredoc RFC. To avoid > issues, please use a heredoc label that does not occur within the string. Hmkay, so code that worked fine with PHP 7.1 and PHP 7.2 breaks with PHP 7.3. This breaking change sho

Re: [PHP-DEV] Parse error: Invalid body indentation level

2018-05-28 Thread Nikita Popov
On Mon, May 28, 2018 at 2:24 PM, Sebastian Bergmann wrote: > Hi! > > https://github.com/sebastianbergmann/diff/blob/ > master/tests/ParserTest.php#L79 > triggers a > > Parse error: Invalid body indentation level (expecting an indentation > level of at least 1) in /path/to/ParserTest.php on line 7

[PHP-DEV] Parse error: Invalid body indentation level

2018-05-28 Thread Sebastian Bergmann
Hi! https://github.com/sebastianbergmann/diff/blob/master/tests/ParserTest.php#L79 triggers a Parse error: Invalid body indentation level (expecting an indentation level of at least 1) in /path/to/ParserTest.php on line 79 with current PHP 7.3.0-dev (master); the code in question works fine with