>when developing a patch like this, it is more readable to do typical
> min max notation to ease readability. That is change:
> if (91 > i && i > 64) {
> To:
> if (64 < i && i < 91) {
>
> the real issue here is that if we fix it this way we break other locales.
How they break? Do you want to s
Hello Tomas,
when developing a patch like this, it is more readable to do typical min
max notation to ease readability. That is change:
if (91 > i && i > 64) {
To:
if (64 < i && i < 91) {
the real issue here is that if we fix it this way we break other locales.
marcus
Thursday, September 6,
I added a note about this. I'm not going to commit the patch, that's for
someone else to decide..
--Jani
On Thu, 2007-09-06 at 13:39 +0300, Tomas Kuliavas wrote:
> I can't add comments on that bug report.
>
> http://www.topolis.lt/php/#35050
>
> Here comes the patch. Only strcasecmp results are
I can't add comments on that bug report.
http://www.topolis.lt/php/#35050
Here comes the patch. Only strcasecmp results are affected. I suspect that
PHP scripts and interpreter itself use same strcasecmp function.
> You are free to send a patch.. :)
>
> If you have objections, please add comment
I'll add comments on 35050 and you will ignore it, because bug is not open.
You have patch on http://bugs.php.net/bug.php?id=35583. I understand why
it might have been rejected. Using mapping table to lowercase ascii is not
optimal solution.
I have other patch, but you are not free to use code li
You are free to send a patch.. :)
If you have objections, please add comment to the report marked as "Wont
fix" and don't spam the already huge database with one more report about
same issue.
--Jani
On Mon, 2007-09-03 at 14:16 +0300, Tomas Kuliavas wrote:
> Hi,
>
> Maybe somebody could provide
Hi,
Maybe somebody could provide good explanation why you can fix the issue
(http://bugs.php.net/bug.php?id=42526). You can't claim that locale
insensitive tolower() breaks things, because your functions are locale
insensitive in some setups.
Now I can only see that PHP developers close bug repor
