Re: [PHP-DEV] PHP Patch for loadHTML options

2011-02-17 Thread James Devine
I've updated bug request #54037 to include a patch which creates HTML specific constants for HTML_PARSE_NODEFDTD and HTML_PARSE_NOIMPLIED, it also creates LIBXML_PEDANTIC and LIBXML_RECOVER constants On Thu, Feb 17, 2011 at 12:52 PM, Christian Stocker wrote: > Hi > > Looks good to me. But can you

Re: [PHP-DEV] PHP Patch for loadHTML options

2011-02-17 Thread Christian Stocker
Hi Looks good to me. But can you add the constants from: typedef enum { HTML_PARSE_RECOVER = 1<<0, /* Relaxed parsing */ HTML_PARSE_NODEFDTD = 1<<2, /* do not default a doctype if not found */ HTML_PARSE_NOERROR = 1<<5, /* suppress error reports */ HTML_PARSE_NOWARNING= 1<<6, /*

Re: [PHP-DEV] PHP Patch for loadHTML options

2011-02-17 Thread James Devine
Will do, thanks! On Thu, Feb 17, 2011 at 6:43 AM, Pierre Joye wrote: > hi, > > Can you make a patch against trunk instead please? > > Also pls follow the CS: > > if (foo) { > } > > Ideally attach your patch to a feature request at bugs.php.net, so we > won't loose it :) > > thanks for your work!

Re: [PHP-DEV] PHP Patch for loadHTML options

2011-02-17 Thread Pierre Joye
hi, Can you make a patch against trunk instead please? Also pls follow the CS: if (foo) { } Ideally attach your patch to a feature request at bugs.php.net, so we won't loose it :) thanks for your work! Cheers, On Thu, Feb 17, 2011 at 12:57 AM, James Devine wrote: > I've included a patch for

[PHP-DEV] PHP Patch for loadHTML options

2011-02-16 Thread James Devine
I've included a patch for review adding the ability to optionally pass options to the DOMDocument::loadHTML[File] functions diff -ru php-5.3.5.orig/ext/dom/document.c php-5.3.5.new/ext/dom/document.c --- php-5.3.5.orig/ext/dom/document.c 2010-04-02 14:08:15.0 -0600 +++ php-5.3.5.new/ext