Re: [PHP-DEV] PHP 5.4.33 RC1 => mod_proxy_fcgi still broken

2014-09-24 Thread Ferenc Kovacs
On Wed, Sep 24, 2014 at 10:12 AM, Remi Collet wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Le 24/09/2014 09:33, Ferenc Kovacs a écrit : > > > We could have used the same NEWS entry from 5.6 I suppose: . Fixed > > bug #67606 (revised fix 67541, broke mod_fastcgi BC). (David > > Zue

Re: [PHP-DEV] PHP 5.4.33 RC1 => mod_proxy_fcgi still broken

2014-09-24 Thread Remi Collet
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 24/09/2014 09:33, Ferenc Kovacs a écrit : > We could have used the same NEWS entry from 5.6 I suppose: . Fixed > bug #67606 (revised fix 67541, broke mod_fastcgi BC). (David > Zuelke) > I fixed NEWS in 5.4 / 5.5 "before" the release (5.4.33 / 5.

Re: [PHP-DEV] PHP 5.4.33 RC1 => mod_proxy_fcgi still broken

2014-09-24 Thread Ferenc Kovacs
On Mon, Sep 15, 2014 at 8:37 AM, Remi Collet wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Le 11/09/2014 09:19, Remi Collet a écrit : > > Le 11/09/2014 09:16, Remi Collet a écrit : > >> Le 09/09/2014 07:54, Stas Malyshev a écrit : The big issue I > >> see, is the news entry: > > >

Re: [PHP-DEV] PHP 5.4.33 RC1 => mod_proxy_fcgi still broken

2014-09-14 Thread Remi Collet
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 11/09/2014 09:19, Remi Collet a écrit : > Le 11/09/2014 09:16, Remi Collet a écrit : >> Le 09/09/2014 07:54, Stas Malyshev a écrit : The big issue I >> see, is the news entry: > >> . Fixed #65641 (PHP-FPM incorrectly defines the SCRIPT_NAME >> var

Re: [PHP-DEV] PHP 5.4.33 RC1 => mod_proxy_fcgi still broken

2014-09-11 Thread Remi Collet
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 11/09/2014 09:16, Remi Collet a écrit : > Le 09/09/2014 07:54, Stas Malyshev a écrit : The big issue I see, > is the news entry: > > . Fixed #65641 (PHP-FPM incorrectly defines the SCRIPT_NAME > variable when using Apache). (David Zuelke) Should p

Re: [PHP-DEV] PHP 5.4.33 RC1 => mod_proxy_fcgi still broken

2014-09-11 Thread Remi Collet
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 09/09/2014 07:54, Stas Malyshev a écrit : > Hi! > > So what is the resolution for this? Should we roll back the fix, > implement the new one and have one more RC, do something else? > Sorry, it seems I have miss your question :( As David Zuelke

Re: [PHP-DEV] PHP 5.4.33 RC1 => mod_proxy_fcgi still broken

2014-09-10 Thread David Zuelke
On 05.09.2014, at 10:54, Remi Collet wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Le 05/09/2014 15:52, David Zuelke a écrit : > >> People should simply use the SetHandler approach instead. > > I agree, see https://bugzilla.redhat.com/1136290 > > But some people may want to use

Re: [PHP-DEV] PHP 5.4.33 RC1 => mod_proxy_fcgi still broken

2014-09-10 Thread David Zuelke
The fix is not broken. He's describing a different/additional issue. Things have always been shaky with ProxyPass (that's https://bugs.php.net/bug.php?id=65641) because it's a bag of hurt. That's the whole reason Apache now has SetHandler for proxies! On 08.09.2014, at 22:54, Stas Malyshev wr

Re: [PHP-DEV] PHP 5.4.33 RC1 => mod_proxy_fcgi still broken

2014-09-08 Thread Stas Malyshev
Hi! So what is the resolution for this? Should we roll back the fix, implement the new one and have one more RC, do something else? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://

Re: [PHP-DEV] PHP 5.4.33 RC1 => mod_proxy_fcgi still broken

2014-09-05 Thread Remi Collet
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 05/09/2014 15:52, David Zuelke a écrit : > People should simply use the SetHandler approach instead. I agree, see https://bugzilla.redhat.com/1136290 But some people may want to use ProxyPass (ex, to redirect to another server, with no PHP script

Re: [PHP-DEV] PHP 5.4.33 RC1 => mod_proxy_fcgi still broken

2014-09-05 Thread David Zuelke
The fixes in that ticket were pretty risky as they very late in the game fiddled with strings. That was brittle should have been fixed earlier during request processing. The new patch (https://bugs.php.net/patch-display.php?bug=65641&patch=Another_fix_for_mod_proxy_fcgi.patch&revision=140992288

Re: [PHP-DEV] PHP 5.4.33 RC1 => mod_proxy_fcgi still broken

2014-09-05 Thread Remi Collet
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 05/09/2014 14:54, Philip Hofstetter a écrit : > Applying the patch fpm_main-script_name-v2.patch proposed on > https://bugs.php.net/bug.php?id=65641 fixes the issue for me. This patch doesn't check for tflag, which seems usefull... Another try

Re: [PHP-DEV] PHP 5.4.33 RC1 => mod_proxy_fcgi still broken

2014-09-05 Thread Philip Hofstetter
On Fri, Sep 5, 2014 at 1:18 PM, Remi Collet wrote: > 2. ProxyPass Configuration > > ProxyPass /proxy/ fcgi://127.0.0.1:9003//var/www/html/ > > URL = /proxy/info.php/a/b?q=a > SCRIPT_NAME = /proxy/info.php/a/b > => Broken This is bugging me too on my development machine where I'm stuck at Ap

Re: [PHP-DEV] PHP 5.4.33 RC1 => mod_proxy_fcgi still broken

2014-09-05 Thread Remi Collet
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Running a test build of 5.4.33RC1. Testing the fix for the SCRIPT_NAME issue 1. SetHandler Configuration SetHandler "proxy:fcgi://127.0.0.1:9003" URL = /info.php/a/b?q=a SCRIPT_NAME = /info.php => OK 2. ProxyPass Configuration