Re: [PHP-DEV] PHP 5.2.7RC3 Reminder

2008-10-30 Thread Pierre Joye
On 10/29/08, Ilia Alshanetsky <[EMAIL PROTECTED]> wrote: > Just a quick reminder for all of the developers, RC3 (the final RC) > will be tagged tomorrow afternoon (EST) time, please try to get > whatever patches (bug fixes only, please) you still want into it. If > there are reasons to delay, criti

Re: [PHP-DEV] PHP 5.2.7RC3 Reminder

2008-10-30 Thread Lars Strojny
Hi Illia, Am Mittwoch, den 29.10.2008, 17:02 -0400 schrieb Ilia Alshanetsky: [...] > Your patch with slight revisions just went in. The sad thing is, that the patch just fixes half of the issue. If your try the examples in the bugreport, most of the still work. We have also check the msgids for o

Re: [PHP-DEV] PHP 5.2.7RC3 Reminder

2008-10-29 Thread Ilia Alshanetsky
Christian, Your patch with slight revisions just went in. On 29-Oct-08, at 11:42 AM, Christian Schneider wrote: Jani Taskinen wrote: http://bugs.php.net/bug.php?id=44938&edit=1 Marked critical but propably isn't. Also depatable whether it's a PHP bug at all.. Probably the library exhausti

Re: [PHP-DEV] PHP 5.2.7RC3 Reminder

2008-10-29 Thread Ilia Alshanetsky
Not a bad idea, although I'd put a limit of the domain length o 4kb. I can't see someone needing a domain longer then that, heck even 1kb should be more then enough. On 29-Oct-08, at 11:42 AM, Christian Schneider wrote: Jani Taskinen wrote: http://bugs.php.net/bug.php?id=44938&edit=1 Mar

Re: [PHP-DEV] PHP 5.2.7RC3 Reminder

2008-10-29 Thread Christian Schneider
Jani Taskinen wrote: > http://bugs.php.net/bug.php?id=44938&edit=1 > > Marked critical but propably isn't. Also depatable whether it's a PHP > bug at all.. Probably the library exhausting memory using alloca I'd say. I whipped together a little patch against HEAD which restricts the length of a

Re: [PHP-DEV] PHP 5.2.7RC3 Reminder

2008-10-29 Thread Ilia Alshanetsky
The problem here is that the domain parameter will eventually make its way into the file path and result in an overflow of the MAX_PATHLEN there (I suspect). The problem however (IMHO) lies in gettext that does not check the file path length before using it. For us to do the check will requ

Re: [PHP-DEV] PHP 5.2.7RC3 Reminder

2008-10-29 Thread Jani Taskinen
Ilia Alshanetsky wrote: Just a quick reminder for all of the developers, RC3 (the final RC) will be tagged tomorrow afternoon (EST) time, please try to get whatever patches (bug fixes only, please) you still want into it. If there are reasons to delay, critical patches missing, please let me kn

[PHP-DEV] PHP 5.2.7RC3 Reminder

2008-10-29 Thread Ilia Alshanetsky
Just a quick reminder for all of the developers, RC3 (the final RC) will be tagged tomorrow afternoon (EST) time, please try to get whatever patches (bug fixes only, please) you still want into it. If there are reasons to delay, critical patches missing, please let me know. Thanks, Ilia