Re: [PHP-DEV] PHP-5.5 unpack change broke pecl/pear

2013-01-13 Thread Remi Collet
Le 14/01/2013 06:57, Sherif Ramadan a écrit : > Please let me know if there are other BC concerns that have not yet come up. Please don't forget that php tree comes with pear/install-pear-nozlib.phar This old archive contains Archive_Tar 1.3.7, so should be updated. (I don't know who st

Re: [PHP-DEV] PHP-5.5 unpack change broke pecl/pear

2013-01-13 Thread Sherif Ramadan
On Sun, Jan 13, 2013 at 11:35 PM, Christopher Jones < christopher.jo...@oracle.com> wrote: > > > On 12/28/2012 01:08 AM, Remi Collet wrote: > >> Le 24/12/2012 04:16, Igor Wiedler a écrit : >> >>> Hi Internals, >>> >>> When test driving PHP-5.5 I ran into issues with a change of unpack >>> behaviou

Re: [PHP-DEV] PHP-5.5 unpack change broke pecl/pear

2013-01-13 Thread Christopher Jones
On 12/28/2012 01:08 AM, Remi Collet wrote: Le 24/12/2012 04:16, Igor Wiedler a écrit : Hi Internals, When test driving PHP-5.5 I ran into issues with a change of unpack behaviour. Archive_Tar which is used by pecl and pear (`pecl install`) uses unpack with the "a" format character. On 5.4 i

Re: [PHP-DEV] PHP-5.5 unpack change broke pecl/pear

2012-12-28 Thread Remi Collet
Le 24/12/2012 04:16, Igor Wiedler a écrit : > Hi Internals, > > When test driving PHP-5.5 I ran into issues with a change of unpack > behaviour. Archive_Tar which is used by pecl and pear (`pecl install`) uses > unpack with the "a" format character. On 5.4 it strips trailing NUL bytes, on > 5.5

Re: [PHP-DEV] PHP-5.5 unpack change broke pecl/pear

2012-12-24 Thread Sherif Ramadan
On Mon, Dec 24, 2012 at 7:13 AM, Anthony Ferrara wrote: > Sherif, > > > You're right. It does break BC, but this was a bug fix. >> https://bugs.php.net/bug.php?id=61038 >> >> The behavior is incorrect in that regard. >> > > However in this case that *bug* does have fairly significant BC > implicat

Re: [PHP-DEV] PHP-5.5 unpack change broke pecl/pear

2012-12-24 Thread Gustavo Lopes
On Mon, 24 Dec 2012 12:13:35 -, Anthony Ferrara wrote: You're right. It does break BC, but this was a bug fix. https://bugs.php.net/bug.php?id=61038 The behavior is incorrect in that regard. However in this case that *bug* does have fairly significant BC implications. In fact, how I

Re: [PHP-DEV] PHP-5.5 unpack change broke pecl/pear

2012-12-24 Thread Daniel Convissor
Hi: On Sun, Dec 23, 2012 at 11:36:14PM -0500, Sherif Ramadan wrote: > On Sun, Dec 23, 2012 at 11:24 PM, Igor Wiedler wrote: > > > In that case I was mistaken regarding the new "Z" char. But "a" has been > > changed. It is noted in the UPGRADING file. > > You're right. It does break BC, but this

Re: [PHP-DEV] PHP-5.5 unpack change broke pecl/pear

2012-12-24 Thread Anthony Ferrara
Sherif, You're right. It does break BC, but this was a bug fix. > https://bugs.php.net/bug.php?id=61038 > > The behavior is incorrect in that regard. > However in this case that *bug* does have fairly significant BC implications. In fact, how I read the specification is that the original binary

Re: [PHP-DEV] PHP-5.5 unpack change broke pecl/pear

2012-12-23 Thread Sherif Ramadan
On Sun, Dec 23, 2012 at 11:24 PM, Igor Wiedler wrote: > In that case I was mistaken regarding the new "Z" char. But "a" has been > changed. It is noted in the UPGRADING file. > > You're right. It does break BC, but this was a bug fix. https://bugs.php.net/bug.php?id=61038 The behavior is incorr

Re: [PHP-DEV] PHP-5.5 unpack change broke pecl/pear

2012-12-23 Thread Sherif Ramadan
This change does not break BC. The "a" format in pack/unpack functions has not changed at all in 5.5. It still does the same thing and it was not replaced by the new "Z" format option, which I added. They do different things. The "a" format strips null bytes from the string. The new "Z" format i

[PHP-DEV] PHP-5.5 unpack change broke pecl/pear

2012-12-23 Thread Igor Wiedler
Hi Internals, When test driving PHP-5.5 I ran into issues with a change of unpack behaviour. Archive_Tar which is used by pecl and pear (`pecl install`) uses unpack with the "a" format character. On 5.4 it strips trailing NUL bytes, on 5.5 it does not. There is a new "Z" format character that c