Re: [PHP-DEV] PDO fetch performance problems with many bindparameters

2020-08-31 Thread Christoph M. Becker
On 29.08.2020 at 09:30, Matteo Beccati wrote: > Hi Christoph, > > On 28/08/2020 22:57, Christoph M. Becker wrote: >> Can we be certain that the relevant bits of the formerly _reserved_flags >> are zero-filled for all existing drivers? > > We can, that's basically the premise of the PR itself: > >

Re: [PHP-DEV] PDO fetch performance problems with many bindparameters

2020-08-29 Thread Matteo Beccati
Hi Christoph, On 28/08/2020 22:57, Christoph M. Becker wrote: > Can we be certain that the relevant bits of the formerly _reserved_flags > are zero-filled for all existing drivers? We can, that's basically the premise of the PR itself: 1. The flags are in the pdo_dbh_t struct which is the dbh->

Re: [PHP-DEV] PDO fetch performance problems with many bindparameters

2020-08-28 Thread Christoph M. Becker
On 28.08.2020 at 20:36, Matteo Beccati wrote: > Hi Gabriel, > >> Let's have this patch merged into PHP 8.0 (`master` branch as of today), I >> have nothing against it.> >> About PHPs 7.3 and 7.4: if the performance improvements are this massive as >> describe in this email, I'm :+1: to have it on

Re: [PHP-DEV] PDO fetch performance problems with many bindparameters

2020-08-28 Thread Christoph M. Becker
On 28.08.2020 at 09:18, Matteo Beccati wrote: > Hi George, > > /cc release managers - pls don't hate me ;-) > > On 27/08/2020 10:23, Matteo Beccati wrote: >> >> On 26/08/2020 19:28, G. P. B. wrote: >>> This can still target PHP 8.0 as this seems to be akin to a bug this >>> might even be applicabl