Re: [PHP-DEV] PCRE error handling patch

2006-04-11 Thread Andrei Zmievski
It's hard to pick a default that will work for everyone. I can probably see setting recursion limit somewhat lower than backtracking one, though. Maybe 100,000/50,000 or something like that. -Andrei On Apr 11, 2006, at 11:51 AM, Nuno Lopes wrote: I would say that 100.000 recursions is too muc

Re: [PHP-DEV] PCRE error handling patch

2006-04-11 Thread Nuno Lopes
I would say that 100.000 recursions is too much. When I made my patch it was segfaulting with such value. 50.000 is a much safer choice (at least on my gentoo box, 8 MB of stack). Nuno - Original Message - I made a patch (against HEAD currently only) that makes it possible to set ru

Re: [PHP-DEV] PCRE error handling patch

2006-04-11 Thread Jani Taskinen
Sounds to me like a bug fix..all those recursion bugs in the db.. :) --Jani On Tue, 11 Apr 2006, Andrei Zmievski wrote: I made a patch (against HEAD currently only) that makes it possible to set runtime limits on backtracking and recursion. It also implements preg_last_error() that l

[PHP-DEV] PCRE error handling patch

2006-04-11 Thread Andrei Zmievski
I made a patch (against HEAD currently only) that makes it possible to set runtime limits on backtracking and recursion. It also implements preg_last_error() that lets users check whether there was an execution error (such as limit exceeded or bad UTF-8 or whatever). Ilia, do you think it migh