Re: [PHP-DEV] PATCH for bug #47199

2010-02-10 Thread Sokolov Evgeniy
Oups. Haven't noticed the attachment. I will try to attach the file again. 2010/2/10 Sokolov Evgeniy : > No problem. I will remember for the future > > 2010/2/10 Pierre Joye : >> Can you attach the patch instead of copying it in your post? Simply >> name it mypatch.txt (.txt is important for the l

Re: [PHP-DEV] PATCH for bug #47199

2010-02-10 Thread Sokolov Evgeniy
No problem. I will remember for the future 2010/2/10 Pierre Joye : > Can you attach the patch instead of copying it in your post? Simply > name it mypatch.txt (.txt is important for the list). > > 2010/2/10 Sokolov Evgeniy : >> Thank you very much. This patch is passed, also as other patches from

Re: [PHP-DEV] PATCH for bug #47199

2010-02-10 Thread Pierre Joye
Can you attach the patch instead of copying it in your post? Simply name it mypatch.txt (.txt is important for the list). 2010/2/10 Sokolov Evgeniy : > Thank you very much. This patch is passed, also as other patches from > this extension. It's time for choose next bug :) > > > > Index: ext/pgsql/

Re: [PHP-DEV] PATCH for bug #47199

2010-02-10 Thread Sokolov Evgeniy
Thank you very much. This patch is passed, also as other patches from this extension. It's time for choose next bug :) Index: ext/pgsql/tests/bug47199.phpt === --- ext/pgsql/tests/bug47199.phpt (revision 0) +++ ext/pgsql/tests

Re: [PHP-DEV] PATCH for bug #47199

2010-02-09 Thread Daniel Convissor
Hi Skolov: > I just run "php tests/27_bug47199.phpt" and check the result output. > Is this correct way? Use an EXPECT or EXPECTF section. See http://qa.php.net/phpt_details.php for more information. Thanks, --Dan -- T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y

Re: [PHP-DEV] PATCH for bug #47199

2010-02-09 Thread Joey Smith
If anyone ever needs me to host a patch, there's more than enough room at patch.joeysmith.com, just email me the patch as an attachment off-list. It'd probably be better than relying on a pastebin. On Tue, Feb 09, 2010 at 04:38:44PM +0100, Johannes Schlüter wrote: > Hi, > > On Tue, 2010-02-09 at

Re: [PHP-DEV] PATCH for bug #47199

2010-02-09 Thread Johannes Schlüter
Hi, On Tue, 2010-02-09 at 20:11 +0500, Sokolov Evgeniy wrote: > > did you really run this test and was it successful? - doesn't looklike > > for me. > I just run "php tests/27_bug47199.phpt" and check the result output. > Is this correct way? The easy way to run it using the test Framework is by

Re: [PHP-DEV] PATCH for bug #47199

2010-02-09 Thread Sokolov Evgeniy
> did you really run this test and was it successful? - doesn't looklike > for me. I just run "php tests/27_bug47199.phpt" and check the result output. Is this correct way? >> Property changes on: tests/27_bug47199.phpt > This isn't needed. Okey, I just use previous test in this dir as example.

Re: [PHP-DEV] PATCH for bug #47199

2010-02-09 Thread Johannes Schlüter
Евгений, thanks for the patch.I didn't fully review it but I wonder about a thing: On Tue, 2010-02-09 at 16:27 +0500, Соколов Евгений wrote: > Index: tests/27_bug47199.phpt > === > --- tests/27_bug47199.phpt(revision 0) > +++ tes

[PHP-DEV] PATCH for bug #47199

2010-02-09 Thread Соколов Евгений
Index: tests/27_bug47199.phpt === --- tests/27_bug47199.phpt (revision 0) +++ tests/27_bug47199.phpt (revision 0) @@ -0,0 +1,23 @@ +--TEST-- +Bug #47199 pg_delete fails on NULL +--SKIPIF-- + +--FILE-- + NULL, 'not_null_field