Re: [PHP-DEV] Optimize zend_string equality check with hash key

2019-04-05 Thread G. P. B.
On Fri, 5 Apr 2019, 09:26 Benjamin Coutu, wrote: > Hello, > > I was surprised to find out that equality checks on zend_string do not > take advantage of the fact that in many cases we have a hash key available > that can be utilized in a quick bailout path without having to resort to a > costly `

[PHP-DEV] Optimize zend_string equality check with hash key

2019-04-05 Thread Benjamin Coutu
Hello, I was surprised to find out that equality checks on zend_string do not take advantage of the fact that in many cases we have a hash key available that can be utilized in a quick bailout path without having to resort to a costly `memcmp` on the value. I recommend to modify `zend_string_e