Re: [PHP-DEV] Old style constructors in PHP-8

2019-01-30 Thread Nikita Popov
On Wed, Jan 30, 2019 at 4:38 PM Andreas Heigl wrote: > > > Am Mittwoch, den 30.01.2019, 09:30 -0600 schrieb Larry Garfield: > > On Wednesday, January 30, 2019 5:41:45 AM CST Nikita Popov wrote: > > > On Wed, Jan 30, 2019 at 12:11 PM Dmitry Stogov > > > wrote: > > > > Hi, > > > > > > > > > > > >

Re: [PHP-DEV] Old style constructors in PHP-8

2019-01-30 Thread Andreas Heigl
Am Mittwoch, den 30.01.2019, 09:30 -0600 schrieb Larry Garfield: > On Wednesday, January 30, 2019 5:41:45 AM CST Nikita Popov wrote: > > On Wed, Jan 30, 2019 at 12:11 PM Dmitry Stogov > > wrote: > > > Hi, > > > > > > > > > I've just noticed that Wordpress-4.1 on PHP master started > > > silent

Re: [PHP-DEV] Old style constructors in PHP-8

2019-01-30 Thread Larry Garfield
On Wednesday, January 30, 2019 5:41:45 AM CST Nikita Popov wrote: > On Wed, Jan 30, 2019 at 12:11 PM Dmitry Stogov wrote: > > Hi, > > > > > > I've just noticed that Wordpress-4.1 on PHP master started silently > > produce different output. > > > > The problem that PHP master started to ignore o

Re: [PHP-DEV] Old style constructors in PHP-8

2019-01-30 Thread Pierre Joye
On Wed, Jan 30, 2019, 6:39 PM Sebastian Bergmann Am 30.01.2019 um 12:15 schrieb Pierre Joye: > > Once officially done, I am sure someone will write code converters as > well. > > The no_php4_constructor fixer of php-cs-fixer has been able to > automatically migrate old-style constructors for years

Re: [PHP-DEV] Old style constructors in PHP-8

2019-01-30 Thread Nikita Popov
On Wed, Jan 30, 2019 at 12:11 PM Dmitry Stogov wrote: > Hi, > > > I've just noticed that Wordpress-4.1 on PHP master started silently > produce different output. > > The problem that PHP master started to ignore old-style constructors. > > They were deprecated in PHP-7 and PHP produced the follow

Re: [PHP-DEV] Old style constructors in PHP-8

2019-01-30 Thread Sebastian Bergmann
Am 30.01.2019 um 12:15 schrieb Pierre Joye: Once officially done, I am sure someone will write code converters as well. The no_php4_constructor fixer of php-cs-fixer has been able to automatically migrate old-style constructors for years. -- PHP Internals - PHP Runtime Development Mailing Li

Re: [PHP-DEV] Old style constructors in PHP-8

2019-01-30 Thread Pierre Joye
On Wed, Jan 30, 2019, 6:11 PM Dmitry Stogov to PHP-8, > > May be, it makes sense to emit fatal error in case of old-style > constructor. > Absolutely yes. It will be painless then to find them and fix accordingly. Once officially done, I am sure someone will write code converters as well. > >

[PHP-DEV] Old style constructors in PHP-8

2019-01-30 Thread Dmitry Stogov
Hi, I've just noticed that Wordpress-4.1 on PHP master started silently produce different output. The problem that PHP master started to ignore old-style constructors. They were deprecated in PHP-7 and PHP produced the following warning Deprecated: Methods with the same name as their class w