Re: [PHP-DEV] Nuking safe_mode

2006-02-18 Thread Andi Gutmans
Thanks Sara. I'll fix accordingly. Please watch my commits on the wrappers and make sure I'm doing the right thing. At 07:40 PM 2/18/2006, Sara Golemon wrote: I'm nuking safe_mode and I found something odd. In streams, php_plain_files_unlink() only checks php_check_open_basedir() when ENFORCE_

Re: [PHP-DEV] Nuking safe_mode

2006-02-18 Thread Sara Golemon
I'm nuking safe_mode and I found something odd. In streams, php_plain_files_unlink() only checks php_check_open_basedir() when ENFORCE_SAFE_MODE is flagged. I was planning on nuking ENFORCE_SAFE_MODE completely. Is this a bug? Or should I rename ENFORCE_SAFE_MODE to ENFORCE_OPEN_BASEDIR? I

Re: [PHP-DEV] Nuking safe_mode

2006-02-18 Thread Andi Gutmans
I just saw we have STREAM_DISABLE_OPEN_BASEDIR. Should I just check if that is 0 and do the open_basedir check in that case? At 05:02 PM 2/18/2006, Andi Gutmans wrote: Hey, I'm nuking safe_mode and I found something odd. In streams, php_plain_files_unlink() only checks php_check_open_basedir()

[PHP-DEV] Nuking safe_mode

2006-02-18 Thread Andi Gutmans
Hey, I'm nuking safe_mode and I found something odd. In streams, php_plain_files_unlink() only checks php_check_open_basedir() when ENFORCE_SAFE_MODE is flagged. I was planning on nuking ENFORCE_SAFE_MODE completely. Is this a bug? Or should I rename ENFORCE_SAFE_MODE to ENFORCE_OPEN_BASEDIR